Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: raoxu <raoxu@uniontech.com>
Cc: mathias.nyman@linux.intel.com, sakari.ailus@linux.intel.com,
	michal.pecio@gmail.com, johannes.bruederl@gmail.com,
	kees@kernel.org, dengjie03@kylinos.cn, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] usb: core: config: fix SS companion log for interrupt endpoints
Date: Thu, 2 Jul 2026 10:39:00 +0200	[thread overview]
Message-ID: <2026070248-fleshy-activity-1a33@gregkh> (raw)
In-Reply-To: <E4E3CED70BF44FF8+20260702081104.2476004-1-raoxu@uniontech.com>

On Thu, Jul 02, 2026 at 04:11:04PM +0800, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
> 
> usb_parse_ss_endpoint_companion() clears bmAttributes when it is
> non-zero for control or interrupt endpoints.
> 
> The diagnostic message reports Control for control endpoints and Bulk
> for the other branch. However, the other branch can only be an
> interrupt endpoint because bulk endpoints are handled by the following
> else-if branch.
> 
> Report the endpoint type as Interrupt instead of Bulk to avoid
> misleading descriptor diagnostics.
> 
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
> ---
>  drivers/usb/core/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Why is this RESEND?  Always say so below the --- line.

thanks,

greg k-h

  reply	other threads:[~2026-07-02  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  8:11 [RESEND PATCH] usb: core: config: fix SS companion log for interrupt endpoints raoxu
2026-07-02  8:39 ` Greg KH [this message]
2026-07-02  9:25   ` [RESEND PATCH] USB: core: report interrupt endpoint correctly in companion descriptor diagnostic raoxu
2026-07-02  9:26   ` raoxu
2026-07-02 11:55     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070248-fleshy-activity-1a33@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dengjie03@kylinos.cn \
    --cc=johannes.bruederl@gmail.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=michal.pecio@gmail.com \
    --cc=raoxu@uniontech.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox