From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Yan <andyshrk@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Yan <andyshrk@163.com>,
badhri@google.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: Fix VDM type for Enter Mode commands
Date: Sat, 4 Jul 2026 13:09:02 +0200 [thread overview]
Message-ID: <2026070408-elude-patronage-9295@gregkh> (raw)
In-Reply-To: <CANbgqAT+B34JNMCnVBg4kk1X_0PX+nFmSgLY6qytRfJ7jnfsaQ@mail.gmail.com>
On Sat, Jul 04, 2026 at 05:41:53PM +0800, Andy Yan wrote:
> Hello,
>
> Heikki Krogerus <heikki.krogerus@linux.intel.com> 于2026年6月5日周五 20:58写道:
> >
> > On Thu, Jun 04, 2026 at 06:50:24PM +0800, Andy Yan wrote:
> > > VDO() second parameter is VDM type (bit 15): 1 for SVDM, 0 for UVDM.
> > > Using 'vdo ? 2 : 1' corrupts SVID low bit when vdo is non-NULL
> > > (2 << 15 = BIT(16)). Enter Mode is always SVDM, hardcode to 1.
> > >
> > > Fixes: 8face9aa57c8 ("usb: typec: Add parameter for the VDO to typec_altmode_enter()")
> > > Signed-off-by: Andy Yan <andyshrk@163.com>
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
>
> Gentle ping....
> Which maintainer can take this patch ?
Please relax, it was just reviewed yesterday. There is obviously no
rush here as it wasn't tagged for stable backports, so it will show up
in the 7.3 kernel release, right?
And as always, if you want patches to get accepted sooner, help out in
reviews to reduce our load.
thanks,
greg k-h
prev parent reply other threads:[~2026-07-04 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 10:50 [PATCH] usb: typec: tcpm: Fix VDM type for Enter Mode commands Andy Yan
2026-06-05 12:54 ` Heikki Krogerus
2026-07-04 9:41 ` Andy Yan
2026-07-04 11:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070408-elude-patronage-9295@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andyshrk@163.com \
--cc=andyshrk@gmail.com \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox