From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Julian Braha <julianbraha@gmail.com>,
Xu Yang <xu.yang_2@oss.nxp.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Chaoyi Chen <kernel@airkyi.com>
Subject: Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE
Date: Thu, 9 Jul 2026 07:31:56 +0200 [thread overview]
Message-ID: <2026070936-apostle-carton-c097@gregkh> (raw)
In-Reply-To: <f0316f09-e78c-495b-8ca9-c7d4fdde3d75@rock-chips.com>
On Thu, Jul 09, 2026 at 11:00:43AM +0800, Chaoyi Chen wrote:
> Hello Greg,
>
> On 7/8/2026 7:51 PM, Greg Kroah-Hartman wrote:
> > On Sun, Jul 05, 2026 at 02:58:32PM +0800, Chaoyi Chen wrote:
> >> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> >>
> >> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
> >> also needed for embedded platforms. Select it when available.
> >>
> >> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
> >> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> >> ---
> >> drivers/usb/typec/altmodes/Kconfig | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
> >> index 7867fa7c405d..1f35b253d6b8 100644
> >> --- a/drivers/usb/typec/altmodes/Kconfig
> >> +++ b/drivers/usb/typec/altmodes/Kconfig
> >> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
> >> config TYPEC_DP_ALTMODE
> >> tristate "DisplayPort Alternate Mode driver"
> >> depends on DRM
> >> + imply DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> >
> > I hate "imply", as this just makes things more complex. Either this is
> > a dependency or not, right? Why not fix that?
> >
>
> Perhaps we can just use the v1 content directly?
> Hopefully that's already simple enough.
>
> https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
Maybe, send it as a v3 and see if the maintainers of those drivers
agree?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-09 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 6:58 [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE Chaoyi Chen
2026-07-05 9:20 ` Julian Braha
2026-07-05 9:37 ` Chaoyi Chen
2026-07-05 11:04 ` Julian Braha
2026-07-06 4:38 ` Xu Yang
2026-07-08 11:51 ` Greg Kroah-Hartman
2026-07-09 3:00 ` Chaoyi Chen
2026-07-09 5:31 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070936-apostle-carton-c097@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chaoyi.chen@rock-chips.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=julianbraha@gmail.com \
--cc=kernel@airkyi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xu.yang_2@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox