Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Sam Day <me@samcday.com>,
	Michael Bommarito <michael.bommarito@gmail.com>,
	Kees Cook <kees@kernel.org>,
	Ingo Rohloff <ingo.rohloff@lauterbach.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_fs: fix __le16 of wMaxPacketSize
Date: Fri, 10 Jul 2026 14:58:52 +0200	[thread overview]
Message-ID: <2026071039-ensure-vastly-73c8@gregkh> (raw)
In-Reply-To: <c1108bc0-190f-4ebd-adb2-51a4a07fc144@codethink.co.uk>

On Wed, Jun 17, 2026 at 10:56:00AM +0100, Ben Dooks wrote:
> On 17/06/2026 10:34, Greg Kroah-Hartman wrote:
> > On Wed, Jun 17, 2026 at 09:59:30AM +0100, Ben Dooks wrote:
> > > The wMaxPacketSize is __le16 type, fix the sparse warnings by changing
> > > the type.
> > > 
> > > Fixes:
> > > 
> > > drivers/usb/gadget/function/f_fs.c:3346:32: warning: incorrect type in assignment (different base types)
> > > drivers/usb/gadget/function/f_fs.c:3346:32:    expected unsigned short [usertype] wMaxPacketSize
> > > drivers/usb/gadget/function/f_fs.c:3346:32:    got restricted __le16 [usertype] wMaxPacketSize
> > > drivers/usb/gadget/function/f_fs.c:3371:36: warning: incorrect type in assignment (different base types)
> > > drivers/usb/gadget/function/f_fs.c:3371:36:    expected restricted __le16 [usertype] wMaxPacketSize
> > > drivers/usb/gadget/function/f_fs.c:3371:36:    got unsigned short [usertype] wMaxPacketSize
> > > 
> > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > > ---
> > >   drivers/usb/gadget/function/f_fs.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> > > index 75912ce6ab55..35d885178b52 100644
> > > --- a/drivers/usb/gadget/function/f_fs.c
> > > +++ b/drivers/usb/gadget/function/f_fs.c
> > > @@ -3332,7 +3332,7 @@ static int __ffs_func_bind_do_descs(enum ffs_entity_type type, u8 *valuep,
> > >   		struct usb_request *req;
> > >   		struct usb_ep *ep;
> > >   		u8 bEndpointAddress;
> > > -		u16 wMaxPacketSize;
> > > +		__le16 wMaxPacketSize;
> > 
> > What commit id does this fix?
> 
> bdcc03cef0fd8 ("usb: gadget: f_fs: preserve wMaxPacketSize across
> usb_ep_autoconfig() call")

Great, can you add that as a Fixes: tag when you resend this?

thanks,

greg k-h

  reply	other threads:[~2026-07-10 12:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17  8:59 [PATCH] usb: gadget: f_fs: fix __le16 of wMaxPacketSize Ben Dooks
2026-06-17  9:34 ` Greg Kroah-Hartman
2026-06-17  9:56   ` Ben Dooks
2026-07-10 12:58     ` Greg Kroah-Hartman [this message]
2026-07-10 14:55       ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071039-ensure-vastly-73c8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=brauner@kernel.org \
    --cc=ingo.rohloff@lauterbach.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@samcday.com \
    --cc=michael.bommarito@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox