Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Cusimano <david@cusimano.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: storage: make ndecimals unsigned in parse_delay_str()
Date: Fri, 17 Jul 2026 06:43:08 +0200	[thread overview]
Message-ID: <2026071745-unheated-sediment-c9df@gregkh> (raw)
In-Reply-To: <!&!AAAAAAAAAAAYAAAAAAAAAEFiSgvv3ohCnt1JqVKYCoXCgAAAEAAAAJls7O2uSQ9AogvVUySzVk4BAAAAAA==@cusimano.com>

On Thu, Jul 16, 2026 at 03:04:00PM -0400, David Cusimano wrote:
> >From 73039aaf92449baf12dd4f774164cab4b9987a5c Mon Sep 17 00:00:00 2001
> From: David Cusimano <david@cusimano.com>
> Date: Thu, 16 Jul 2026 14:04:29 -0400
> Subject: [PATCH] usb: storage: make ndecimals unsigned in parse_delay_str()

Something went really wrong with your email system, this shouldn't be
here, and your patch is corrupted :(

> 
> The ndecimals parameter controls how many decimal places are added when the
> expected suffix is missing. It is never used as a signed quantity, so make
> it
> unsigned to better reflect its intended semantics.

While nice, is this needed?  Are you going to do this for all usages in
this file of the same thing?

We use "int" a lot in the kernel, so be aware that this is going to be
an interesting task, if not kind of pointless?

thanks,

greg k-h

      reply	other threads:[~2026-07-17  4:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 19:04 [PATCH] usb: storage: make ndecimals unsigned in parse_delay_str() David Cusimano
2026-07-17  4:43 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071745-unheated-sediment-c9df@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=david@cusimano.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox