From: Lucas De Marchi <ldemarchi@nvidia.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
demarchi@kernel.org, Lucas De Marchi <ldemarchi@nvidia.com>
Subject: [PATCH 3/3] xhci: dbgtty: Drop extra call to idr_destroy()
Date: Mon, 20 Jul 2026 17:27:16 -0300 [thread overview]
Message-ID: <20260720202716.76000-3-ldemarchi@nvidia.com> (raw)
In-Reply-To: <20260720202716.76000-1-ldemarchi@nvidia.com>
idr_destroy() is already called on error paths in dbc_tty_init(). Do not
call it again on exit. For symmetry with the init side, also use
IS_ERR_OR_NULL() to gate the exit steps.
Signed-off-by: Lucas De Marchi <ldemarchi@nvidia.com>
---
drivers/usb/host/xhci-dbgtty.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c
index 7e44e62d6ea9..3d51e8d82659 100644
--- a/drivers/usb/host/xhci-dbgtty.c
+++ b/drivers/usb/host/xhci-dbgtty.c
@@ -665,11 +665,11 @@ int dbc_tty_init(void)
void dbc_tty_exit(void)
{
- if (dbc_tty_driver) {
- tty_unregister_driver(dbc_tty_driver);
- tty_driver_kref_put(dbc_tty_driver);
- dbc_tty_driver = NULL;
- }
+ if (IS_ERR_OR_NULL(dbc_tty_driver))
+ return;
+ tty_unregister_driver(dbc_tty_driver);
+ tty_driver_kref_put(dbc_tty_driver);
idr_destroy(&dbc_tty_minors);
+ dbc_tty_driver = NULL;
}
--
2.54.0
prev parent reply other threads:[~2026-07-20 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 20:27 [PATCH 1/3] xhci: dbgtty: Fix unregister on tty_register_driver() failure Lucas De Marchi
2026-07-20 20:27 ` [PATCH 2/3] xhci: dbgtty: Fix unregister on tty_alloc_driver() failure Lucas De Marchi
2026-07-20 20:27 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720202716.76000-3-ldemarchi@nvidia.com \
--to=ldemarchi@nvidia.com \
--cc=demarchi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox