From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45FC207DF7; Fri, 24 Jul 2026 05:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784870145; cv=none; b=c557LH7sOL/JFgyoyo8DuJ+x8HzDpd2u3dZ+qYGiuU6YHb3ODIV2+GWFJ8kHSpFNemSh7IZH4DfojckEV7mDoLN5sNtvYaUeA7/YYbNYpv0hC88AVIynRqjrUzrR9DaQjkqDBVzp7pPKR7Igr3QXXDcb1slYSZfYafMUFYHR8/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784870145; c=relaxed/simple; bh=LQZc4rIna5P6w5GjBtRUSMmbad/eKzzcgHBBcPUi+a8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EtpUWiQWXVDsr5+zAqE8gNgOQ/c1tHjuktZLXi62flYM6zaZTLfv2xKUSvWlLZiUocM899qj/BbonQOedOS4xoYVsXGGg4qNgPRv7U7gmzK9d+FGQ/OVWhpX/fJm0FUfHzxofRol9RD4iO93Upz0oSHm/vdbxjfp+ZLseHUiX+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=A2gRWfKu; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="A2gRWfKu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1784870141; bh=3vAgljkxOZKzaYntzYofEQoz0xcOMVn5Ns3RtQoLP38=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=A2gRWfKuLncrBaRNDxtNhxbceU9i65FV7UALKBRZtKPRc6HiFXGU/O8sf619aWw3j odbVPyhZ7J2Q42l9J5eKFz6uI04Mr0eEw5n1GTq5uzAAdkXhiR0cY3kWaUPQCAWTNp cRRySDdA8vk0ggWIOxz5GhHMGLS9QxWTmk682fbF7yuedFiTPR1O3jjkgF8quuyPei xTmJjDoeUyPjf4lbu82fVXyGrrlkr9DG/lXhRaq8nFbbW68y6Mc4bBNvcsi0PEVdbQ 1ZpW4tVbKEzj/5xsx8jObgYTviXRn/s8VSwaaNVYiZxV/A/UMllzJJa8MhJ87DV7oM 1XjZIq1QM4tCw== Received: by codeconstruct.com.au (Postfix, from userid 10000) id 9CADD66F3A; Fri, 24 Jul 2026 13:15:41 +0800 (AWST) From: Jeremy Kerr Date: Fri, 24 Jul 2026 13:15:23 +0800 Subject: [PATCH net-next v5 02/12] net: mctp: usb: Use packet-length max for maximum packet-size check Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-dev-mctp-usb-1-1-v5-2-e66bbba0dbdc@codeconstruct.com.au> References: <20260724-dev-mctp-usb-1-1-v5-0-e66bbba0dbdc@codeconstruct.com.au> In-Reply-To: <20260724-dev-mctp-usb-1-1-v5-0-e66bbba0dbdc@codeconstruct.com.au> To: Matt Johnston , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org X-Mailer: b4 0.16-dev The max packet size is smaller than the max transfer size, as we only have a u8 length field in the transport header. Add a define for the maximum representable length, and use that for our check. Use this for the MTU maximum calculation too. Signed-off-by: Jeremy Kerr --- drivers/net/mctp/mctp-usb.c | 2 +- include/linux/usb/mctp-usb.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mctp/mctp-usb.c b/drivers/net/mctp/mctp-usb.c index 545eff06322c..c6e36b63e87a 100644 --- a/drivers/net/mctp/mctp-usb.c +++ b/drivers/net/mctp/mctp-usb.c @@ -76,7 +76,7 @@ static netdev_tx_t mctp_usb_start_xmit(struct sk_buff *skb, plen = skb->len; - if (plen + sizeof(*hdr) > MCTP_USB_1_0_XFER_SIZE) + if (plen + sizeof(*hdr) > MCTP_USB_1_0_PKTLEN_MAX) goto err_drop; rc = skb_cow_head(skb, sizeof(*hdr)); diff --git a/include/linux/usb/mctp-usb.h b/include/linux/usb/mctp-usb.h index 47e2e3931d63..2bece8afd1c7 100644 --- a/include/linux/usb/mctp-usb.h +++ b/include/linux/usb/mctp-usb.h @@ -25,7 +25,8 @@ struct mctp_usb_hdr { #define MCTP_USB_1_0_XFER_SIZE 512 #define MCTP_USB_BTU 68 #define MCTP_USB_MTU_MIN MCTP_USB_BTU -#define MCTP_USB_1_0_MTU_MAX (U8_MAX - sizeof(struct mctp_usb_hdr)) +#define MCTP_USB_1_0_PKTLEN_MAX U8_MAX +#define MCTP_USB_1_0_MTU_MAX (MCTP_USB_1_0_PKTLEN_MAX - sizeof(struct mctp_usb_hdr)) #define MCTP_USB_DMTF_ID 0x1ab4 #endif /* __LINUX_USB_MCTP_USB_H */ -- 2.47.3