From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880DB3DAAAC for ; Fri, 24 Jul 2026 08:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882666; cv=none; b=skHfE8KDt0iP2FcgD2UQzLlTtyOKX7SzdxOxvYXezqp0aptkGsmWioitVBLL8U6DFKvTAgGDDH00SKT05Ikam+K7bet/U6wUX1vgKSLZzc9q1UEqhAYpIVOeCZibpu3+/ngg/AqlFJxeAI1YXAFNj9kcb7UuUk3A7LZyJW9ghqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882666; c=relaxed/simple; bh=nDUhaI/csnrSHq2VN8yN7twClkIbPM+mTJRxHI6rupU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mkSv1qt+hca5M/W1uzFL/0LrUdrnkeqUKa3b6g0QTH8VI/bcoydvkmFxhRLa7w6ECtsN+hOwoIkGaYUUZzl9fQbr5p2LQbrpZUwGrCHMJCHkmHfudZrY0xXzvP+vIMUrhiv6/m2J2PQn+donubxYeewfHdijmxTbydX2la1EVs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CmKpXFIY; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CmKpXFIY" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-382ef647e20so170792a91.1 for ; Fri, 24 Jul 2026 01:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882664; x=1785487464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=CmKpXFIY2fz0FEh1sBN5K1MITqW6gA3deUByIwLLyRKlpL8Y/MaJytDIqBrNa0/Tt5 ljLVkmAIQRnPQNpfB1hDuG2LnAC1j9Wk0fUFM/xkU2F9OIbB7PGkSYRFhJtLRzc2cNrR NGBFe4Ii44lPSM+VRSDegxZtWTEppi/5ci6vA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882664; x=1785487464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=bqNX+aAQtfpIWkk0Sw2muNgAFS8SRlUBl80fWk/+FV7PNWZp4s+25EbeWxe+N4X2ks DgFTGGGciDUimY1kKfySK8tpRKXsaKOmpWpxbTAM3FfoAHYRvHcSPzEaoYDhv0l6EZuw Nw07AN+foRwlTFEx6z/FhTpDsCmxArETHakRrnjNUHS7c5upaSORaWhkH9Wo8yXFTZUy EL9o5/Ar7YjFVDA8X1w5N5qQGONH6wA0dbzo55T17lU0RkkeEctRiezNgjfei7SWAxhi 9bLp0zrJl/vIJ8LeY2BNeS+VpupCo1Z67rWR3vZAGC/R2Avo0q8ljl8fZu23brM+aD8g Wgdg== X-Forwarded-Encrypted: i=1; AHgh+RqsrJ0Vdj490a6v03eLCjwAqJCOy0lV1rhM3Tj0Cbba4AUmws/YbAoZE1GPHDwtz+6BYdPcLVfW0qQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyW3G0trWcZwfYiY1VCpt73FloQg5gPdDG82sHQPDVHNtY7TqUG PMLTpVEOu6+yNnQCX06U9IDSf8n5s2wskpKU0WIUelJFBsLnLRCeGjQJn4OPkmyaRg== X-Gm-Gg: AR+sD12EU2eQfkwpL4ThukHIXEnMkP/JLgN3A91cXo+OON2oc3Z1X4hacXbYNwTjMdY I+5c2olC7cfu5SNEBfNHEXbnKEWyRRNG2cA4pbKULJhmEAX3CjoFLsEqJzBy7049sceeKkvbWIs 8Y4793Y3bwe1oGDB/GKRguVhopGVACAOrqwBwgFO2yHjOZHVQ3R+PZlLkZOhNj2GwbmPalqfyJv nNkE6OUEhQf+yVmgsUToP9KEN5p+5OC+CBvK+/S8hyLb4mTbs8csg32jzAZLEXMPN2TZ/kkLKDL II64U8O6y2E++eCLULJY/cYOwi2kyEMDCc4/vfyd7sB9D00H+SjvqX4T4ZkbeowhkYvWRwpmbye rLCiHdWGZKcrcBaJKUeR/4hr7+sEZ4LsYQ71nyhUiC/YZHzSbHlGQPRh+DXM+v40HObaD86Syfo P5/pgSeCtkXNByDqROUq7rRgTDrxZE62mqIXaemsCIhkpR9Imy5Dnot1qer5GbWVMfQIQecg== X-Received: by 2002:a17:90b:314a:b0:381:23d5:693f with SMTP id 98e67ed59e1d1-38ec65f9916mr6632501a91.28.1784882663919; Fri, 24 Jul 2026 01:44:23 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:23 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Date: Fri, 24 Jul 2026 16:43:13 +0800 Message-ID: <20260724084328.3943997-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_hub_set_port_power() open-codes assign_bit(). Just use the assign_bit() macro instead. This makes subsequent additions to usb_hub_set_port_power() easier to read. This change does not introduce any functional changes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Bartosz Golaszewski Signed-off-by: Chen-Yu Tsai --- Attributing suggestion to Andy, since the change was originally requested as part of a review. Changes since v4: - New patch (split out from "usb: hub: Power on connected M.2 E-key connectors with power sequencing API") (Andy) --- drivers/usb/core/hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 2cfe09a141d8..715f26f05a31 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -10,6 +10,7 @@ * Released under the GPLv2 only. */ +#include #include #include #include @@ -899,10 +900,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, if (ret) return ret; - if (set) - set_bit(port1, hub->power_bits); - else - clear_bit(port1, hub->power_bits); + assign_bit(port1, hub->power_bits, set); return 0; } -- 2.55.0.229.g6434b31f56-goog