Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: skyexpoc <skyexpoc@gmail.com>
Cc: linux-kernel@vger.kernel.org, Hans de Goede <hansg@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
	Israel Cepeda <israel.a.cepeda.lopez@intel.com>
Subject: Re: [PATCH 0/3] usbio: fix two out-of-bounds accesses and a hang
Date: Sun, 26 Jul 2026 13:43:14 +0200	[thread overview]
Message-ID: <2026072638-construct-overload-c30b@gregkh> (raw)
In-Reply-To: <e6ce9251-fcaa-4833-ae6b-12a5d46415ba@Canary>

On Sun, Jul 26, 2026 at 08:32:25PM +0900, skyexpoc wrote:
> I’m sorry. I should have included an attribution.
> That was my oversight.
> 
> I did use an LLM this time to assist with the audit and translation. It performed variant analysis on the code around 8c6314489550, identified these three issues, and wrote the patches and changelog. I ran the build, reviewed the results, decided what was worth submitting, and sent everything out. The Signed-off-by line is mine, and I take responsibility for this work.

Yes, but the LLM did _all_ the work here, that's not good, you can't
rely on it being correct (hint, you also sent an html email here which
the mailing list rejected...)

> I have now read ⁠coding-assistants.rst and ⁠generated-content.rst. The following has been added to all three patches in v2:
> 
> Assisted-by: Claude:claude-opus-5 asan
> 
> The cover letter also explains what the tool did and what I did. There are no code changes compared with v1.

And the LLM got this all wrong, again, please don't assume that what
they spit out is correct.  I see on average, only 2/3 of the patches
they create are proper.  Given my initial review of your first patch,
those odds are still in play here...

thanks,

greg k-h

  reply	other threads:[~2026-07-26 11:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26  7:59 [PATCH 0/3] usbio: fix two out-of-bounds accesses and a hang HE WEI (ギカク)
2026-07-26  7:59 ` [PATCH 1/3] usb: misc: usbio: reject endpoints smaller than the packet header HE WEI (ギカク)
2026-07-26  7:59 ` [PATCH 2/3] i2c: usbio: reject bridges with undersized transfer buffers HE WEI (ギカク)
2026-07-26  7:59 ` [PATCH 3/3] usb: misc: usbio: bound the debug hex dumps by the received length HE WEI (ギカク)
2026-07-26 11:09 ` [PATCH 0/3] usbio: fix two out-of-bounds accesses and a hang Greg Kroah-Hartman
2026-07-26 11:32   ` skyexpoc
2026-07-26 11:43     ` Greg Kroah-Hartman [this message]
2026-07-26 11:59       ` HE WEI(ギカク)
2026-07-26 12:18         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072638-construct-overload-c30b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andi.shyti@kernel.org \
    --cc=hansg@kernel.org \
    --cc=israel.a.cepeda.lopez@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=skyexpoc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox