From: Jakub Kicinski <kuba@kernel.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: linux-kernel@vger.kernel.org, Stefano Brivio <sbrivio@redhat.com>,
netdev@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org, jarod@redhat.com,
stable@vger.kernel.org
Subject: Re: [PATCH net v2] usbnet: cap max_mtu for drivers without bind callback
Date: Wed, 29 Jul 2026 17:52:18 -0700 [thread overview]
Message-ID: <20260729175218.15b5d081@kernel.org> (raw)
In-Reply-To: <20260727072304.154608-1-lvivier@redhat.com>
On Mon, 27 Jul 2026 09:23:04 +0200 Laurent Vivier wrote:
> - if ((dev->driver_info->flags & FLAG_NOMAXMTU) == 0 &&
> - net->max_mtu > (dev->hard_mtu - net->hard_header_len))
> + if (dev->driver_info->flags & FLAG_NOMAXMTU)
> + net->max_mtu = ETH_MAX_MTU;
> + else
> net->max_mtu = dev->hard_mtu - net->hard_header_len;
Sashikos point out that this will causes issues for existing drivers in
both directions. Some drivers explicitly set max_mtu. So we need to move
the
net->max_mtu = ETH_MAX_MTU;
line before the call to ->bind ?
--
pw-bot: cr
prev parent reply other threads:[~2026-07-30 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:23 [PATCH net v2] usbnet: cap max_mtu for drivers without bind callback Laurent Vivier
2026-07-30 0:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729175218.15b5d081@kernel.org \
--to=kuba@kernel.org \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=sbrivio@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox