From: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
To: mika.westerberg@linux.intel.com
Cc: YehezkelShB@gmail.com, andreas.noever@gmail.com,
atharvatiwarilinuxdev@gmail.com, bhelgaas@google.com,
bp@alien8.de, dave.hansen@linux.intel.com, dev@deq.rocks,
dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com,
hansg@kernel.org, hpa@zytor.com, ilpo.jarvinen@linux.intel.com,
jarkko@kernel.org, jmorris@namei.org, keyrings@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-usb@vger.kernel.org, mingo@redhat.com, paul@paul-moore.com,
platform-driver-x86@vger.kernel.org, roberto.sassu@huawei.com,
serge@hallyn.com, tglx@kernel.org, westeri@kernel.org,
x86@kernel.org, zohar@linux.ibm.com
Subject: Re: [PATCH v5 2/2] thunderbolt: Add device links for Apple T2 NHI
Date: Wed, 29 Jul 2026 14:35:24 -0400 [thread overview]
Message-ID: <20260729183524.1199-1-atharvatiwarilinuxdev@gmail.com> (raw)
In-Reply-To: <20260728044841.GP2365036@black.igk.intel.com>
> We should not be calling PCI functions anymore from the SW CM core. We have
> pci.c for that.
That is outside the scope of this patch, this should be another patch.
> I wonder if we can put this to pci.c, rename it to tb_pci_add_links()
> instead.
Same thing as before, its outside the scope of this patch.
> BTW, why you need to differentiate T2 vs. the rest of Apple x86? Don't this
> variable do?
Because the Patchset is specifically for T2 Macs.
> I'm not fan of __free() and the like so let's not use it here.
>
> Also you don't need to scan all the slots. Just look for the tunneled
> downstream ports based on their PCI IDs like we do already.
Could you please point me to the "like we do already" code you're referring to?
> This is unrelated change.
Its not. the patch specifically says T2 macs, and Titan ridge is only on T2 Macs
so we dont need to use has_apple_t2_chip for that.
prev parent reply other threads:[~2026-07-29 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 21:18 [PATCH v5 0/2] Add Apple T2 NHI device links Atharva Tiwari
2026-07-27 21:18 ` [PATCH v5 1/2] treewide: Add a flag to detect the Apple T2 chip Atharva Tiwari
2026-07-28 0:58 ` Borislav Petkov
2026-07-27 21:18 ` [PATCH v5 2/2] thunderbolt: Add device links for Apple T2 NHI Atharva Tiwari
2026-07-28 4:48 ` Mika Westerberg
2026-07-29 18:35 ` Atharva Tiwari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729183524.1199-1-atharvatiwarilinuxdev@gmail.com \
--to=atharvatiwarilinuxdev@gmail.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dev@deq.rocks \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=hansg@kernel.org \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=paul@paul-moore.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=tglx@kernel.org \
--cc=westeri@kernel.org \
--cc=x86@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox