From: Greg KH <gregkh@linuxfoundation.org>
To: Jeffin Philip <jeffinphilip14@gmail.com>
Cc: felipe.balbi@linux.intel.com, christophe.jaillet@wanadoo.fr,
kees@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+791be35f1fbcc85d06d7@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: fix null pointer dereference in fsg_common_set_num_buffers()
Date: Mon, 17 Aug 2026 13:10:27 +0200 [thread overview]
Message-ID: <2026081701-glitzy-hush-b284@gregkh> (raw)
In-Reply-To: <20260817110839.8201-1-jeffinphilip14@gmail.com>
On Mon, Aug 17, 2026 at 04:38:39PM +0530, Jeffin Philip wrote:
> In fsg_common_set_num_buffers(), n can be 0 as conversion to u8
> using kstrtou8() in fsg_opts_num_buffers_store() can return
> values from _0_ to 255. When passing 0 as "n" value to kzalloc_objs,
> it can return a ZERO_SIZE_PTR, which passes the null check for
> buffhds.
But that is probably a bad idea, right? Shouldn't we fix that error
first?
thanks,
greg k-h
next prev parent reply other threads:[~2026-08-17 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 11:08 [PATCH] usb: gadget: f_mass_storage: fix null pointer dereference in fsg_common_set_num_buffers() Jeffin Philip
2026-08-17 11:10 ` Greg KH [this message]
2026-08-17 13:02 ` Jeffin Philip
2026-08-17 13:15 ` Greg KH
2026-08-17 14:01 ` Alan Stern
2026-08-17 16:03 ` Jeffin Philip
2026-08-17 16:09 ` Jeffin Philip
2026-08-17 16:49 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026081701-glitzy-hush-b284@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=felipe.balbi@linux.intel.com \
--cc=jeffinphilip14@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+791be35f1fbcc85d06d7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox