From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA68341D22A; Tue, 18 Aug 2026 08:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040554; cv=none; b=lnBXhEPIMyoZ3ypTUR84pNKc75KxR9HhcW6gvxPZu0/xWEGJRhZUAfxuD0SfzA06+Sx2+ZQ82MZerOz9jkhH4wWKNuWY74kTxWqgI45f/fYUr4jixbOQo2c2baosnjOJ6obv+5sHBezR6G94lyXsLVQU9U4xv2wFiyX7doed1Jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040554; c=relaxed/simple; bh=9qj85whLX6xAuRYCqLauDAAjftox+zxA7A2TQ1IAHRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oHdW6q3YVQPQEamBB+UO7RKVgPUls5Lcc6cBrAAWjEYdRapYkk4sKer2o9NHt7igmAI+nb2UgqR/cx6QxTM4OoKtATcEkFsfJgKS3DZZe5/iXWBsXj60DeqtRIOXiqJM84ooNRJ6kWkyf43G6hc+jXpvHhUnVDUvEqWtPnZgpjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gMDn1pQm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gMDn1pQm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 690BB1F00A3E; Tue, 18 Aug 2026 08:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787040552; bh=KxoJzPksuK2FDItQJn1AHAFzrtCR8dkvo26/KvGtqwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gMDn1pQmV05dOdAY/pzoI+YyNdsCaN65uiMrqKC7ujrwsnbKmc+WDTRQjXuw8V05m qYXYyUA/IHhp3OcXyxIzRK/ynvWv7mL52b31BzAsiVPnOS5wFrhnV9aSsz24QpS0oX SvmWezaxRBV1BAaSZGeR5tkRZ6JFdNNliMEvPnv1A8O1UJvZVMSf/LKEERRNvS3BJ7 vxF4/LgC624RTmgWmngE9tCqYmENzTgbjUl5emrNQ9OEdZtyUbZp2BnNzHQa21Uuzq YiyfaxAAIE85WLhYOcI3EW0NY0w5ak3SIBUh4OAxxVyI/zYzPTsp4uk6AtmzBvtAxt Qg1+dBXUEsJCg== Date: Tue, 18 Aug 2026 10:09:02 +0200 From: Krzysztof Kozlowski To: Marek Vasut Cc: linux-usb@vger.kernel.org, Pankaj Dev , Rahul Kumar , Fabrice Gasnier , =?utf-8?Q?Cl=C3=A9ment?= Le Goffic , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rob Herring , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY Message-ID: <20260818-imperious-thankful-perch-dcaa44@quoll> References: <20260816213849.1044073-1-marex@nabladev.com> <20260816213849.1044073-2-marex@nabladev.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260816213849.1044073-2-marex@nabladev.com> On Sun, Aug 16, 2026 at 11:37:03PM +0200, Marek Vasut wrote: > From: Pankaj Dev >=20 > Document USB2 PHY for STM32MP25 USB2 controllers, which includes the > USB2.0 host-only controller and USB 2.0 part of the DWC3 controller. > Two such PHYs in total are present in STM32MP25 SoC, they both are > slightly different, therefore they use different compatible string > to discern them. >=20 > Co-developed-by: Pankaj Dev > Signed-off-by: Pankaj Dev Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > Co-developed-by: Rahul Kumar > Signed-off-by: Rahul Kumar > Co-developed-by: Fabrice Gasnier > Signed-off-by: Fabrice Gasnier > Co-developed-by: Cl=C3=A9ment Le Goffic > Signed-off-by: Cl=C3=A9ment Le Goffic > Signed-off-by: Marek Vasut > --- > Cc: Alexandre Torgue > Cc: Christian Bruel > Cc: Conor Dooley > Cc: Fabrice Gasnier > Cc: Greg Kroah-Hartman > Cc: Krzysztof Kozlowski > Cc: Maxime Coquelin > Cc: Neil Armstrong > Cc: Pankaj Dev > Cc: Rahul Kumar > Cc: Rob Herring > Cc: Rosen Penev > Cc: Thinh Nguyen > Cc: Vinod Koul > Cc: devicetree@vger.kernel.org > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-phy@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-usb@vger.kernel.org > --- > V2: - Fix up Sob/Cdb lines > - Fix up compatible string in example > - Use additionalProperties: false > - Expand description: > - Use clock-cells =3D <1> to discern OSC and future PLL clock from th= e PHY > --- > .../bindings/phy/st,stm32-usb2phy.yaml | 73 +++++++++++++++++++ I do not see any changes/improvements from previous review. Best regards, Krzysztof