Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Rys <martin@archlinux.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: Improve "New device found" printout message
Date: Sun, 30 Aug 2026 08:21:02 +0200	[thread overview]
Message-ID: <2026083045-antitrust-sacrifice-ffa9@gregkh> (raw)
In-Reply-To: <6323ed34-7954-4f0b-b6c5-8e1b1ffc1648@archlinux.org>

On Sat, Aug 29, 2026 at 08:38:04PM +0200, Martin Rys wrote:
> >From c5b92273e0b7e2f095cab876603d37a1f4530175 Mon Sep 17 00:00:00 2001
> From: Martin Rys <martin@archlinux.org>
> Date: Sat, 29 Aug 2026 20:26:44 +0200
> Subject: [PATCH v2] USB: Improve "New device found" printout message

Nit, why is this in the body of the email?

> 
> Use a colon instead of a comma, like the debug message after this one does.
> 
> Do not print a space after `bcdDevice=` - this was introduced as the formatting was copied from `lsusb -v` printout, but lsusb output has preceding spaces, this message does not, so it ends up looking odd.

Please wrap your changelog text at 72 columns.  I thought checkpatch.pl
would warn about this, did it not?

thanks,

greg k-h

  reply	other threads:[~2026-08-30  6:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 18:38 [PATCH v2] USB: Improve "New device found" printout message Martin Rys
2026-08-30  6:21 ` Greg KH [this message]
2026-08-30  7:56   ` Martin Rys
2026-08-30  8:14     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026083045-antitrust-sacrifice-ffa9@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin@archlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox