From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A7A131E49; Fri, 4 Sep 2026 00:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788481619; cv=none; b=aOqUtot6xLvv9Gn6dmPA2zTEb2KSN2n7vYkFMANG4LWU/DE/MRvtdAJW1YkJDdHwJs2CoClKYxGJMwcdU237FmRxZRDXEOSQLoj83Hm/waSW//PTj69ReW8ers6HP56385ZseX0cIU4bmDkARImnjh2MIzLLoSu2t64IZLFp5Nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788481619; c=relaxed/simple; bh=YIrU1a5LIk8R8UmC4YvL7asVO1wT4Xei6fV+VatqJp4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=lqaC9ZDAkKS3rDyWIqPoVHCK+8Q2AMBogJ3E6NPZlcQvXqccBI1rwdgCLKtbwQu8khWmyFjkOnYL+37jw6qXuyVXQmRPd58mpI9Jg9FyNFZhDfeE2QuWVgZ1X0LV6qe9tFNbW7b8qQ6by+aoxpYDtsMmKPYSo95Q2MgMbjc3/Hk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ug91L3qe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ug91L3qe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 336831F000E9; Fri, 4 Sep 2026 00:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788481617; bh=OWri4F0Svaj3nnPmZom/8lW/4zU2p7+FpDTOdKpLxjk=; h=From:To:Subject:Date; b=Ug91L3qeN3VWPF/oWIIteU79HpBhrHU56r0rR0vYbGUXaS/XDVxZTJg1CZIXg2bD1 m/ztJErq9m683IV9tp0+V1gC9QdDjwTYhK+SdXCyV/Rq3nwou8qUoSgT8ad7eQCYDz biK8vrFyS1Wx+Fb73eJy4m7VIl8Lng4qRmTkSbggv4oeOgSd6v6RaBAiRAm5AaFV7M G+9wNebQMcUBzHUK0dL5gErh6Rajvakja0hZ3hJHMagVb76LqPNzuOGasn0xmqHs/N 3ydxrzufkKLr7fFL4ymJVkMXwJMJ0HiNCA6fh6pqdKgZav5BFoEWxHuwFaCabzABiG 9wlx2gXKW+6eQ== From: Damien Le Moal To: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Niklas Cassel , linux-usb@vger.kernel.org, Alan Stern , Greg Kroah-Hartman , linux-s390@vger.kernel.org, Heiko Carstens Subject: [PATCH v3 00/40] Use defined 16-bits ASC/ASCQ combinations Date: Fri, 4 Sep 2026 09:26:04 +0900 Message-ID: <20260904002644.157668-1-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Martin, James, This patch series defines as macros all ASC/ASCQ combinations present in https://www.t10.org/lists/asc-num.txt and converts the SCSI core code and SCSI low level drivers to use these macros instead of hard-coded ASC/ASCQs. To do this, struct scsi_sense_hdr and struct scsi_failure are modified to replace the asc and ascq 8-bits fields with a 16-bits sense_code field. This cleans up the code in many places and makes it easier, and self documented, to test sense codes in the case of errors. Overall, there should be no functional chnages here. Note: this dwiseries currently applies cleanly to Linus tree, but will have a conflict with a libata fix patch that will be sent out for 7.3rc2. Changes from v2: - Removed unintended duplication of KUNIT_EXPECT_EQ() call in patch 7 (Sashiko comment). - Improved patch 38 to directly use 16-bits sense code instead of passing only an ascq around (Sashiko comment). - Added missing local variable initialization in spc_emulate_request_sense() in patch 34 (Sashiko comment). - Added review tags Sashiko also did comment about several pre-existing issues for different drivers, but I am not addressing these issues in this series. Changes from v1: - Addressed Sashiko comments signaling missing "ASC_" prefix when using the named macros for ASC codes. - Fixed up patch 7 to correct trace event print of asc/ascq. Also extended the use of scsi_set_sense() in place of scsi_build_sense(). - Modified patch 37 to extend the use of scsi_set_sense_buffer() in place of scsi_build_sense_buffer(). - Added patch 34 and 38 to extend the use of scsi_set_sense() in place of scsi_build_sense(). - Added patch 40 to remove scsi_build_sense() and scsi_build_sense_buffer(). Damien Le Moal (40): scsi: define all additional sense codes and their qualifiers scsi: constants: use defined sense codes scsi: constants: rename internal struct field names scsi: rename sense field of struct scsi_failure scsi: prepare for using 16-bits defined sense codes scsi: use struct scsi_sense_hdr to log sense keys and codes scsi: core: use 16-bits defined sense codes scsi: sd: use 16-bits defined sense codes scsi: sr: use 16-bits defined sense codes scsi: ses: use 16-bits defined sense codes scsi: ch: use 16-bits defined sense codes scsi: st: use 16-bits defined sense codes scsi: device_handlers: hp_sw: use 16-bits defined sense codes scsi: device_handlers: rdac: use 16-bits defined sense codes scsi: device_handlers: emc: use 16-bits defined sense codes scsi: device_handlers: alua: use 16-bits defined sense codes scsi: mpt3sas: use 16-bits defined sense codes scsi: mpi3mr: use 16-bits defined sense codes scsi: 3w-xxxx: use 16-bits defined sense codes scsi: leapraid: use 16-bits defined sense codes scsi: megaraid: use 16-bits defined sense codes scsi: myrX: use 16-bits defined sense codes scsi: smartpqi: use 16-bits defined sense codes scsi: qla2xxx: use 16-bits defined sense codes scsi: ps3rom: use 16-bits defined sense codes scsi: lpfc: use 16-bits defined sense codes scsi: stex: use 16-bits defined sense codes scsi: mvumi: use 16-bits defined sense codes scsi: libiscsi: use 16-bits defined sense codes scsi: ibmvscsi_tgt: use 16-bits defined sense codes scsi: scsi_debug: use 16-bits defined sense codes scsi: hpsa: use 16-bits defined sense codes scsi: storvsc: use 16-bits defined sense codes target: use 16-bits defined sense codes usb: storage: use 16-bits defined sense codes cdrom: use 16-bits defined sense codes ata: libata: use 16-bits defined sense codes s390: scsi: use 16-bits defined sense codes scsi: cleanup scsi_proto.h scsi: remove scsi_build_sense() and scsi_build_sense_buffer() drivers/ata/libata-eh.c | 13 +- drivers/ata/libata-sata.c | 20 +- drivers/ata/libata-scsi.c | 346 ++- drivers/ata/libata.h | 5 +- drivers/cdrom/cdrom.c | 10 +- drivers/s390/scsi/zfcp_ext.h | 2 +- drivers/s390/scsi/zfcp_fsf.c | 9 +- drivers/s390/scsi/zfcp_scsi.c | 6 +- drivers/scsi/3w-xxxx.c | 3 +- drivers/scsi/ch.c | 55 +- drivers/scsi/constants.c | 61 +- drivers/scsi/device_handler/scsi_dh_alua.c | 55 +- drivers/scsi/device_handler/scsi_dh_emc.c | 28 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 29 +- drivers/scsi/device_handler/scsi_dh_rdac.c | 55 +- drivers/scsi/hpsa.c | 69 +- drivers/scsi/hpsa_cmd.h | 23 - drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 +- drivers/scsi/leapraid/leapraid_func.h | 7 - drivers/scsi/leapraid/leapraid_os.c | 15 +- drivers/scsi/libiscsi.c | 3 +- drivers/scsi/lpfc/lpfc_scsi.c | 18 +- drivers/scsi/megaraid.c | 8 +- drivers/scsi/megaraid/mega_common.h | 2 - drivers/scsi/megaraid/megaraid_mbox.c | 12 +- drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +- drivers/scsi/mpi3mr/mpi3mr_os.c | 50 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 69 +- drivers/scsi/mvumi.c | 2 +- drivers/scsi/myrb.c | 67 +- drivers/scsi/myrs.c | 23 +- drivers/scsi/ps3rom.c | 5 +- drivers/scsi/qla2xxx/qla_isr.c | 9 +- drivers/scsi/scsi.c | 3 +- drivers/scsi/scsi_common.c | 24 +- drivers/scsi/scsi_debug.c | 332 +-- drivers/scsi/scsi_error.c | 94 +- drivers/scsi/scsi_ioctl.c | 3 +- drivers/scsi/scsi_lib.c | 133 +- drivers/scsi/scsi_lib_test.c | 95 +- drivers/scsi/scsi_logging.c | 22 +- drivers/scsi/scsi_scan.c | 22 +- drivers/scsi/scsi_transport_spi.c | 12 +- drivers/scsi/sd.c | 126 +- drivers/scsi/sd_zbc.c | 2 +- drivers/scsi/sense_codes.h | 2496 ++++++++++++------ drivers/scsi/ses.c | 23 +- drivers/scsi/smartpqi/smartpqi_init.c | 31 +- drivers/scsi/sr.c | 3 +- drivers/scsi/sr_ioctl.c | 29 +- drivers/scsi/st.c | 35 +- drivers/scsi/stex.c | 3 +- drivers/scsi/storvsc_drv.c | 15 +- drivers/target/target_core_spc.c | 11 +- drivers/target/target_core_transport.c | 11 +- drivers/target/target_core_ua.c | 28 +- drivers/target/target_core_ua.h | 7 +- drivers/usb/gadget/function/f_mass_storage.c | 34 +- drivers/usb/gadget/function/storage_common.h | 71 +- drivers/usb/storage/debug.c | 12 +- drivers/usb/storage/debug.h | 4 +- drivers/usb/storage/transport.c | 7 +- include/scsi/scsi_cmnd.h | 3 +- include/scsi/scsi_common.h | 16 +- include/scsi/scsi_dbg.h | 6 +- include/scsi/scsi_device.h | 26 +- include/scsi/scsi_proto.h | 71 +- include/scsi/scsi_sense.h | 943 +++++++ include/trace/events/scsi.h | 4 +- 69 files changed, 3829 insertions(+), 2015 deletions(-) create mode 100644 include/scsi/scsi_sense.h -- 2.55.0