From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oneukum@suse.com>,
Marco Crivellari <marco.crivellari@suse.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Petko Manolov <petkan@nucleusys.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 net-next 5/6] net: usb: pegasus: Move long delayed work on system_dfl_long_wq
Date: Mon, 7 Sep 2026 11:12:02 +0200 [thread overview]
Message-ID: <20260907091202.hnFpCqFV@linutronix.de> (raw)
In-Reply-To: <b6e6e8d0-0888-4bbc-85b8-ca3bdac88398@rowland.harvard.edu>
On 2026-09-05 12:33:07 [-0400], Alan Stern wrote:
> > Still the wrong thing to do? The driver should do either flush_work() or
> > cancel_work_sync() (not flush_workqueue()).
>
> I think we're in agreement. If the driver relies on calling
> flush_workqueue(), it should not use a general-purpose workqueue.
> However, flush_work() or cancel_work_sync() is okay on an unordered
> general-purpose workqueue.
Perfect, thank you.
> If Oliver still has any objections, he can raise them.
Okay. So far this is good to go ;)
> Alan Stern
Sebastian
next prev parent reply other threads:[~2026-09-07 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260720100902.155605-1-marco.crivellari@suse.com>
2026-07-20 10:08 ` [PATCH v3 net-next 5/6] net: usb: pegasus: Move long delayed work on system_dfl_long_wq Marco Crivellari
2026-07-22 8:29 ` Oliver Neukum
2026-08-25 15:18 ` Sebastian Andrzej Siewior
2026-08-27 16:01 ` Alan Stern
2026-08-28 9:43 ` Sebastian Andrzej Siewior
2026-08-28 14:10 ` Alan Stern
2026-09-04 15:01 ` Petko Manolov
2026-09-05 15:04 ` Sebastian Andrzej Siewior
2026-09-05 16:33 ` Alan Stern
2026-09-06 8:08 ` Petko Manolov
2026-09-07 9:12 ` Sebastian Andrzej Siewior [this message]
2026-07-20 10:08 ` [PATCH v3 net-next 6/6] net: usb: r8152: " Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907091202.hnFpCqFV@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=petkan@nucleusys.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox