From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32843911DC for ; Thu, 10 Sep 2026 20:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789073586; cv=none; b=rclxCnkTbJQvMx1CizQaQFeC/JM968h2WECzGBJYZ8hm20YJDhhI4dfhxboQWCTdYc+8TLvBcocuFPH/3ljEkXkt3GobweWiy+MoutAdT9teh00HVV/QmwaMhSIgatyB68nR4dNEA4GazPk5LZROMVEuDwBSxUPQWGwztvPYzRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789073586; c=relaxed/simple; bh=4myePDbGOuuvFHg/eT5rjXj67qALj6mkkV+jO0qZ1ho=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h7LvWKMseDq3D0cuzeLrxbJSKsDQQsW8Gj/q+iev3Tfu09SHlVlARS5JlDVv9wFR2JpE6UHTQzcMXPo+t3rjr1HQhdQUYjnfwPAF9ica1FjRPBQf/B/792lXBEk3usxei4zc3vnvJOAwTjbXffoVuAgdcBLxK8T6N3+56k9RCmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VMDGbFsy; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VMDGbFsy" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49cd77e0f95so2212295e9.3 for ; Thu, 10 Sep 2026 13:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789073583; x=1789678383; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BCq0kuHs1j0acWRuibtXq3pLZmgmsIKMo87HdJz9dU8=; b=VMDGbFsy6VMjqvGLqOaUxZGHQrYUg1H344c6DejVFMBJXEOFz/QKXHkB+dyqwTjZsN nbWBolb8oFeMoQDB6AahiL/6jjYzWYPKNDxP0XZpOVFNLZaFm+Ft3eCHUbZPbTL9DCSR fyQlqujw+CHCHtol2vCocfzGTbgFfiMSXaBMdCKI5p0f2XZrGR07GzqAb5eF495qpGcg TuofGOFe2NSrZKOOEnV7EE1dIEI9Sga6FEUKPuFiV1Ip6XDlcJ7jvNLpJsLFQxvcQNoP uhD7CqeUGXZNL/lNq8Dx2hYxnDdn93EAnRomu4pS+Q+eOzw4u1gfZUbJTykLWnn34NU9 nEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789073583; x=1789678383; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BCq0kuHs1j0acWRuibtXq3pLZmgmsIKMo87HdJz9dU8=; b=pdgzaaaMacbW8hxuutq1VvldUyOiXnk4AUcDuL3Wz+3M+UwSONaUtdxvwptqtdumQw TO1gUMvjLhyV1rE7EAr3mKoj7WXaKoXnlzEbbRsS6+Lf8GyuLT6+eysMy+m3g172FGzO Ji32OQYnQbUw91fVbXSTE/FKJ9Zj8m4XAPrP/pAoJi48iVcoUepEWmk29SXOk3fyNIc7 p5Ojf+wd62JcW6Mz8DeBgRO4n9IrhOREpq+RqgqD3GNSQT/bPk0wrRppPK5Vzduwl38A 08UMDidKSp1IR0ROCc1dUQR1G61SsvJLzjVmkMROXzj/z6VFHWjMZoFxzzlFBFGCg7MC otkw== X-Forwarded-Encrypted: i=1; AKwUvByTecXjIPUyFybp8qS6E3UrxYrBJzM6h2YcwTnGnjstuUv2Z4BhIqpuvN7trnpdfymzAjZVJLZ+2U8=@vger.kernel.org X-Gm-Message-State: AFuF++n6lW5qKU7ud6qV9OuyDcV2ZVZe5crBAwEIuYRl9Fwb+GApqppn n0ur6cQl+9JThrLOWYqLQ5dCjwq32VoIGeGmMLhJpTLajfVuHvbMAj5Y X-Gm-Gg: AYBFou2T063sb53K7WvJA/LIokcrUBTvIeVT+wAPWydVaZoLd3zXQOTvgH+FRBiyE2V hchnJMpYHw3Fg/mbYXiqPWA6Mubsqm2BgACq82db+5LpsIxsusGgpc1NLGidbZU0nEcthRWRy0X hr+ggNb7/zNnI6ZHzwMMURgORDXQrCmeepn2FSUH0Pu0+FhlrRh+U9UcCkDkuaf2dR492sD9cN1 ukBWdBE7E53rO1rh9fplDB0kqxOkMBzFkmTxzW3gQcn9JDR5W/rLk1bfE1cicTGiIMYy3+gHD/F gkMk0p9bWcRcOae28eLThebx7o9SVZ/2oa3NUdrziQ94Hh0EKAhZr3R49TRjcO1DSr7fJykgKiC aTwF9v+SFT3D1mcOIlsTDSWLXMQlMyCha15d7PtAoynO9ED6pA0QWK8fBTeq7/9VWU1XKDXmtvE 3eTmHDcFUqrAa+doXG87dBNYECVpCqjPp3KKeVLWh0WdixcOavE+zRmxxi9210NzXxTvmayDhaO rYF7axw X-Received: by 2002:a05:600c:1385:b0:49c:fc6e:a3d5 with SMTP id 5b1f17b1804b1-49e619bfebcmr7617295e9.20.1789073583150; Thu, 10 Sep 2026 13:53:03 -0700 (PDT) Received: from foxbook (bfg95.neoplus.adsl.tpnet.pl. [83.28.44.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26c38e3asm106663825e9.9.2026.09.10.13.53.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 10 Sep 2026 13:53:02 -0700 (PDT) Date: Thu, 10 Sep 2026 22:52:59 +0200 From: Michal Pecio To: Mario Limonciello Cc: Curtis Vogt , Jiri Kosina , Benjamin Tissoires , Greg Kroah-Hartman , Pierre-Loup Griffais , open list , "open list:HID CORE LAYER" , "open list:USB SUBSYSTEM" Subject: Re: [PATCH 2/3] HID: valve-index: Reboot headset on system power transitions Message-ID: <20260910225259.66b480c6.michal.pecio@gmail.com> In-Reply-To: <55918a70-72c9-4f55-934b-81a692d4619b@amd.com> References: <20260910170254.833871-1-mario.limonciello@amd.com> <20260910170254.833871-3-mario.limonciello@amd.com> <20260910220421.40356e51.michal.pecio@gmail.com> <55918a70-72c9-4f55-934b-81a692d4619b@amd.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 10 Sep 2026 15:43:18 -0500, Mario Limonciello wrote: > >> +/* > >> + * The headset's EDID service is lost when the host disables the DisplayPort > >> + * PHY during system suspend, so it needs the reboot on the way out of > >> + * suspend. Doing it on the way in does not work: the headset dropping off > >> + * USB is a remote-wakeup event from its hub and aborts the suspend. > >> + */ > > > > The internal hub which will be quirked by the next patch, or its parent? > > It has to be the internal hub if quirking it works, no? I believe there are two separate problems here: 1. resetting the device at suspend causes instant wakeup 2. a few seconds later the system wakes up anyway 1. is solved by resetting on resume rather than suspend 2. is solved by the quirk Questions: Any chance that 2 also solves 1? Would resetting on suspend be preferable, as the comment suggests? Maybe it would, if the reset can race with DP seeing empty EDID? Regards, Michal