Linux USB
 help / color / mirror / Atom feed
From: Xu Yang <xu.yang_2@oss.nxp.com>
To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, jun.li@nxp.com
Subject: [PATCH] usb: typec: pd: mark usb_power_delivery sysfs devices as PM not required
Date: Mon, 14 Sep 2026 17:39:23 +0800	[thread overview]
Message-ID: <20260914093923.1910484-1-xu.yang_2@oss.nxp.com> (raw)

From: Xu Yang <xu.yang_2@nxp.com>

The usb_power_delivery device tree (pd, capabilities, and pdo objects
created by usb_power_delivery_register()/_capabilities(), and add_pdo())
is a pure sysfs representation with no PM callbacks of its own.

TCPM's state machine runs in its own kthread and is not synchronized with
the system PM core's suspend/resume sequencing. A Type-C wakeup interrupt
can resume the system and let TCPM register a partner's source/sink
capabilities (and their PDOs) before the parent device's device_complete()
has cleared its power.is_prepared flag. When this happens, device_pm_add()
observes the parent's stale is_prepared state and prints a spurious:

  source-capabilities: PM: parent pd1 should not be sleeping

This is harmless but confusing. Mark all three device (pd, cap and pdo)
types with device_set_pm_not_required() so PM core will skip dpm_list
tracking for them entirely.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 drivers/usb/typec/pd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c
index 766c76d63328..a200d1f50977 100644
--- a/drivers/usb/typec/pd.c
+++ b/drivers/usb/typec/pd.c
@@ -517,6 +517,7 @@ static int add_pdo(struct usb_power_delivery_capabilities *cap, u32 pdo, int pos
 	p->dev.parent = &cap->dev;
 	p->dev.type = type;
 	dev_set_name(&p->dev, "%u:%s", position + 1, name);
+	device_set_pm_not_required(&p->dev);
 
 	ret = device_register(&p->dev);
 	if (ret) {
@@ -579,6 +580,7 @@ usb_power_delivery_register_capabilities(struct usb_power_delivery *pd,
 	cap->dev.parent = &pd->dev;
 	cap->dev.type = &pd_capabilities_type;
 	dev_set_name(&cap->dev, "%s", cap_name[cap->role]);
+	device_set_pm_not_required(&cap->dev);
 
 	ret = device_register(&cap->dev);
 	if (ret) {
@@ -715,6 +717,7 @@ usb_power_delivery_register(struct device *parent, struct usb_power_delivery_des
 	pd->dev.type = &pd_type;
 	pd->dev.class = &pd_class;
 	dev_set_name(&pd->dev, "pd%d", pd->id);
+	device_set_pm_not_required(&pd->dev);
 
 	ret = device_register(&pd->dev);
 	if (ret) {
-- 
2.34.1


             reply	other threads:[~2026-09-14  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  9:39 Xu Yang [this message]
2026-09-18  7:58 ` [PATCH] usb: typec: pd: mark usb_power_delivery sysfs devices as PM not required Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914093923.1910484-1-xu.yang_2@oss.nxp.com \
    --to=xu.yang_2@oss.nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=imx@lists.linux.dev \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox