From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: YehezkelShB@gmail.com, andreas.noever@gmail.com,
duoming@zju.edu.cn, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, westeri@kernel.org
Subject: Re: [PATCH] thunderbolt: Fix tunnel reference leak in tb_dp_dprx_start()
Date: Fri, 18 Sep 2026 06:58:10 +0200 [thread overview]
Message-ID: <20260918045810.GC106095@black.igk.intel.com> (raw)
In-Reply-To: <20260917155231.2161107-1-vulab@iscas.ac.cn>
Hi,
On Thu, Sep 17, 2026 at 03:52:31PM +0000, Wentao Liang wrote:
> The extra tunnel reference taken to keep the tunnel around while
> tunnel->dprx_work is pending is only dropped in tb_dp_dprx_stop() when
> cancel_delayed_work() reports that it canceled a pending work. For
> tunnels created by tb_tunnel_discover_dp() there is no callback, so no
> work is queued and that condition is never true, leaking the reference
> on every activation.
There are bunch of fixes in my fixes branch that I think real with this one
too (and they make the callback mandatory) please check if that's the case.
prev parent reply other threads:[~2026-09-18 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 15:52 [PATCH] thunderbolt: Fix tunnel reference leak in tb_dp_dprx_start() Wentao Liang
2026-09-18 4:58 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918045810.GC106095@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=duoming@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox