From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1619C3C660C for ; Mon, 21 Sep 2026 23:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032141; cv=none; b=Ileoy7aM3J1CgD7L5Xfo8SvAe5lcjB8Kscbt0wif7wa5MkJIqi53/LU067BqAReOFXk+tdAIdnNcKEsqnojmRYCqrn7Y4/ZnUyyy/paDL2SEVPTscAuBTCm0OMQSCpNsY4gBi1tk+x7jU2wwG0j7a4eHQtTm65zwI5GEAik9kOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790032141; c=relaxed/simple; bh=kAvYqeh9lhIbm8YtKATUVDPt4SSV0dL/01lCzjcwo3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZPU+vJHEdLzPSWC/1oQAw5OM5KsOn/GPn0//uuLVpPVk/lgd3p2RI/CRT+c0xqAiC2k14m0AQmYXQmIYJXE+IzAEwb5eIlpffO3sk4ohWycG35yz7wv7iL2yxkK2hqYM8+T1x02KBN8YIw8r4oc3CW0IitFB1+DYq6fQ3Sb/hZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QyZUYmCF; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QyZUYmCF" Received: by mail-qk2-f12.google.com with SMTP id af79cd13be357-93a2dea320fso347784285a.2 for ; Mon, 21 Sep 2026 16:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790032138; x=1790636938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=81aKjimYrYOGXnfGd1vfh7o17MNAV+GZaQTkl+KjGW8=; b=QyZUYmCFqcGdPDyj4LBCoxHGM3l8H92abHSqBj5QZZpXopqZSyK2Q5bFOaguO9b/IO amUpJJWphzwIfhp3awJ0SEoCjqA2VbDlYzYpgOKHbPlesrGdT0qY/Jz84vj6s17+ua89 1pvcqTcZo8KcPzZlN9W8Lll3MUCQd9md+Clz6fqwOISzSx+mRNW0oXxexnynFvql6sC2 qzFI9M5TvlTf/k5I7pxJDKtj8xhEGw2i9ZuWQ0J2ou2tF06iXVDSsYTYvc+n+ZXCt/+F qVmrGJY8P+2Mk/JUgyJ7MOSeF0tn7BiBDUJCXiMgq2YE1awp3nDuFx5EDA2643Rb1U9w lR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790032138; x=1790636938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=81aKjimYrYOGXnfGd1vfh7o17MNAV+GZaQTkl+KjGW8=; b=L1YDzIr9SkDvAgsplhB2jHXGX8/VnEH1Ou88aiwfMFGziHM0WHu5YnMo+w0JqGKbAx ZnNikmuxz8YJf+pz5F7S7USENtRaAcNNq2E9bO0FnY0nK4kn6y+RXg0ElHjPOUbGvp4g EKm47NT0e33BUO/VI9krZXw8nKsaKEXfViIk7SwMhTodXYBgrSLdPIglTNaVBnFxW3YQ +NYypdMxkA9Y0Nr65dCZpOI5N8kek/QKtuAg+JgvMz0jzOSRKcZMJUHHs3qvC/OBL7Y9 jeJfg4CWuvQZOjJ98rwnWeE3DIuy2ELP8qV6Ycz7T3L0kMbSdovQyhoZit3b38Jhp5OP Wdig== X-Gm-Message-State: AFuF++k/zrsS11XFi/OpyEsONnixcq8aCy618nO8uS5MNejJxXlskdVZ ntZkLipZC1BuBP7jquapFegzNvU/py1PiQXop6+y2vs93Ef4lt3K+Hw= X-Gm-Gg: AYBFou2y8n6rJOPHkc78ZRFW7eBNGEQlxxsbcnhqsjGHJUkUvFdetrm6rXZpTYe4BTs WatKHPCDdMNSO7DvT86FEVQRG4/3yx8p2H0Tqqvn7h0C0alkfM1rPeSclkepykjmjtHVEiUQ+Zi mZw1B3oASWOTeS/GAon8hAo+RwkF88l07sWUSqKGPew+0SbgG2/O5PMbmBTgDZIn/RxZxUN1XWy uYo74N3StteofN5/S6iTnsM6+EOapr6yI1neA0ja2hKgva4sBVYWfVT+qdzlNHV86ML7+fjiC5m HfRgcuXubRnG8rnRuS3seQsvpaz6et5XedNzCDXpW2T0dvVv5xeKOmS2quTmNkAqW7WM17NRXk1 F+4ZAe0/Z4xxxAz5ZUybP3r2fxJXnC8uS6RW0EcTItHn7arYQSn297YqtwmTRdzd6NPWeERFRZ1 sv8clVIbLJ6VIFaoeC3ASfO1oSEzFFFXDsuWt3omLJ8eMCK3StNZv1jHEHQpbFyMLh6sLTgfcf8 1ytd8cHZH1qjf207V2nv4V3LLNMb2aWlMZhq9rHnTjkBqoipPcbGj+jpDer6LmHyJ8sNOIpT0xl BgMZgjzPztQaDGY9JqT+sXJIWF++ X-Received: by 2002:a05:620a:6f0c:b0:939:feaa:949c with SMTP id af79cd13be357-93c15eed484mr268135185a.36.1790032137800; Mon, 21 Sep 2026 16:08:57 -0700 (PDT) Received: from i4-gl-tmk5904-1.ad.psu.edu ([130.203.156.90]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93c19a7f592sm39933985a.17.2026.09.21.16.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 16:08:57 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Ijae Kim , stable@vger.kernel.org Subject: [PATCH v2 2/2] usb: gadget: tegra-xudc: Disable reset delayed works Date: Mon, 21 Sep 2026 19:08:48 -0400 Message-ID: <20260921230849.502492-3-mhun512@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260921230849.502492-1-mhun512@gmail.com> References: <20260921230849.502492-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The devm port-status IRQ stays registered through remove() and can queue port_reset_war_work and plc_reset_work after cancel_delayed_work_sync() returns. remove() never stops the first. disable_delayed_work_sync() drains both and rejects a later queue. usb_role_sw_work stays on cancel_work_sync(). The PHY notifier is its producer and is unregistered before this cancel. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mode controller") Cc: stable@vger.kernel.org # 6.10+ Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Keep the Fixes tag on one line. (Thierry Reding) - Disable plc_reset_work too. The port-status IRQ can requeue it. (Thierry Reding) drivers/usb/gadget/udc/tegra-xudc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c index a0585a1f19f0..dd0a033b4a7f 100644 --- a/drivers/usb/gadget/udc/tegra-xudc.c +++ b/drivers/usb/gadget/udc/tegra-xudc.c @@ -3932,7 +3932,8 @@ static void tegra_xudc_remove(struct platform_device *pdev) &xudc->vbus_nb); } - cancel_delayed_work_sync(&xudc->plc_reset_work); + disable_delayed_work_sync(&xudc->port_reset_war_work); + disable_delayed_work_sync(&xudc->plc_reset_work); cancel_work_sync(&xudc->usb_role_sw_work); usb_del_gadget_udc(&xudc->gadget); -- 2.53.0