Linux USB
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: brandon.proulx@42fifty.dev
Cc: "westeri@kernel.org" <westeri@kernel.org>,
	"andreas.noever@gmail.com" <andreas.noever@gmail.com>,
	"YehezkelShB@gmail.com" <YehezkelShB@gmail.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: Thunderbolt: reboot hangs in nhi_pci_remove() with CalDigit TS5 Plus on AMD Strix Halo
Date: Tue, 29 Sep 2026 08:40:08 +0200	[thread overview]
Message-ID: <20260929064008.GK106095@black.igk.intel.com> (raw)
In-Reply-To: <nxr6GV-FbflB2r0-2kRJbGFFyhMIfL7FKPuvjeV2X_vzpxf5SRcLoS-DTT2022-tzGIegm3GxbSXLMAF9ri8frabpjm4KwTw9MYRekLmRuA=@42fifty.dev>

On Mon, Sep 28, 2026 at 08:29:55PM +0000, brandon.proulx@42fifty.dev wrote:
> 
> Hi Mika,
> 
> Yes. Those fixes clear the hang on my system.
> 
> I could not boot the fixes branch as-is. It is based on 7.3-rc1, and this system runs 7.2.5-3-omarchy. I applied these four commits onto the 7.2.5 thunderbolt driver and loaded that module:
> 
> • thunderbolt: Fix domain reference leak when DPRX read is canceled
> • thunderbolt: Don't access a DP tunnel after its DPRX read was canceled
> • thunderbolt: Mark discovered tunnels as active
> • thunderbolt: Tear down inactive DP tunnels when the domain is stopped
> 
> Before that, unbinding 0000:c5:00.6 with the TS5 Plus attached blocked in nhi_pci_remove() at wait_for_completion(&nhi->domain_released), and reboot(2) stuck in the same place until I held the power button. dprx_timeout is 12000, but the wait lasted many minutes.
> 
> With the patched module, that unbind returned in about a second and the dock came back on rebind. A normal systemctl reboot then finished: systemd unmounted the filesystems and the machine reset, instead of sitting on the splash.
> 

Great to hear that it helped :)

      reply	other threads:[~2026-09-29  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  2:06 Thunderbolt: reboot hangs in nhi_pci_remove() with CalDigit TS5 Plus on AMD Strix Halo brandon.proulx
2026-09-26 10:13 ` Mika Westerberg
2026-09-28 20:29   ` brandon.proulx
2026-09-29  6:40     ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929064008.GK106095@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=brandon.proulx@42fifty.dev \
    --cc=linux-usb@vger.kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox