Linux USB
 help / color / mirror / Atom feed
From: Aleksei Berezin via B4 Relay <devnull+8967858b87.gmail.com@kernel.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Aleksei Berezin <8967858b87@gmail.com>
Subject: [PATCH] usb: typec: ucsi: acpi: Add quirk for ASUS ROG Zephyrus Duo 16 GX650PI
Date: Fri, 09 Oct 2026 02:41:19 +0400	[thread overview]
Message-ID: <20261009-usb-next-v1-1-95a2288ad9b2@gmail.com> (raw)

From: Aleksei Berezin <8967858b87@gmail.com>

On the ASUS ROG Zephyrus Duo 16 (GX650PI, BIOS GX650PI.314) the firmware
loads the EC-based variant of the AMD CPM UCSI SSDT ("CPMUCSI"). Its _DSM
read function only copies MESSAGE_IN and CCI from the EC into the shared
mailbox and never fills in the VERSION field. The only code that sets the
version (M31F) lives in the "UCSIPLT" SSDT of the I2C-based variant, which
is present in the firmware image but not loaded on this machine.

As a result ucsi_register() reads a zero version and the probe fails
silently with -ENODEV, so neither Type-C port is registered and no
typec, usb_power_delivery or ucsi-source-psy devices are created.

Reuse the existing zero-version workaround from the Acer Nitro ANV15-41
quirk and assume UCSI 1.2 on this machine. With this change both ports,
the PD partner and the UCSI power supplies are registered and report the
connected USB PD charger correctly.

Assisted-by: Claude Opus 5.5 iasl
Signed-off-by: Aleksei Berezin <8967858b87@gmail.com>
---
 drivers/usb/typec/ucsi/ucsi_acpi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
index 5697ccc24..c8e6efdba 100644
--- a/drivers/usb/typec/ucsi/ucsi_acpi.c
+++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
@@ -196,6 +196,13 @@ static const struct dmi_system_id ucsi_acpi_quirks[] = {
 		},
 		.driver_data = (void *)&ucsi_acer_ops,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "GX650PI"),
+		},
+		.driver_data = (void *)&ucsi_acer_ops,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),

---
base-commit: 42bcac323cc3b16566fed8c5b250318ad02a0de0
change-id: 20261009-usb-next-98711bc6d682

Best regards,
--  
Aleksei Berezin <8967858b87@gmail.com>



             reply	other threads:[~2026-10-08 22:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 22:41 Aleksei Berezin via B4 Relay [this message]
2026-10-08 22:45 ` [PATCH] usb: typec: ucsi: acpi: Add quirk for ASUS ROG Zephyrus Duo 16 GX650PI sashiko-bot
2026-10-09 11:44 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261009-usb-next-v1-1-95a2288ad9b2@gmail.com \
    --to=devnull+8967858b87.gmail.com@kernel.org \
    --cc=8967858b87@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox