From: Christoph Hellwig <hch@lst.de>
To: 胡连勤 <hulianqin@vivo.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michael.christie@oracle.com>,
Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"usb-storage@lists.one-eyed-alien.net"
<usb-storage@lists.one-eyed-alien.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] scsi: sd: mark disk dead on surprise host removal to avoid I/O hang
Date: Mon, 12 Oct 2026 16:49:23 +0200 [thread overview]
Message-ID: <20261012144923.GA10852@lst.de> (raw)
In-Reply-To: <TYUPR06MB6217DD31B1B3CD09E431CC12D2922@TYUPR06MB6217.apcprd06.prod.outlook.com>
On Fri, Oct 09, 2026 at 11:29:36AM +0000, 胡连勤 wrote:
> unsigned short_inquiry:1;
>
> + /* Device is physically gone; skip sync in sd_remove() */
> + unsigned surprise_removal:1;
Placing this right in the middle of static fields is a bit weird.
Maybe we should get started with an unsigned long and atomic bitops
for something like that actually is known to set it at any point in
runtime and thus most suspect to corruption non-atomic bitfields?
next prev parent reply other threads:[~2026-10-12 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 11:29 [PATCH v5 1/2] scsi: sd: mark disk dead on surprise host removal to avoid I/O hang 胡连勤
2026-10-12 14:49 ` Christoph Hellwig [this message]
2026-10-13 2:14 ` 答复: " 胡连勤
2026-10-13 15:22 ` Bart Van Assche
2026-10-13 8:14 ` [usb-storage] " Oliver Neukum
2026-10-13 9:14 ` 答复: " 胡连勤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012144923.GA10852@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hulianqin@vivo.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mkp@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox