From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 791EC2AD0C for ; Sun, 18 Oct 2026 22:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792362839; cv=none; b=opGUVf7cVBJ6KTMP+CnESfokw5/wdDCUFbTtyMIc+/OBh3T3K4nYf+bzguIIrAc2icE18Lv4Luc/4bL4yoaJiZoxxgNPegCYootf3qHyOpT36HqaZ03ipdiOPFxaK8bHLdlJ4IOpgNgY3UPNiroxbm/jPz5TEEaKmaBCzjAOopw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792362839; c=relaxed/simple; bh=NgHHSA7vGYxQapF/98NDvmot1QWdaK+fbvCUOkKE4rE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PR8kaXj708MVp44qJ5N/pNbqkORG48bnJE2FL4s58y1rFkHmwjT6aI+/LgC1kbdmH19goHKpFuP9SpnF8rskUUGWNWeZMvm5CNrQZUeIKQcoBCMoStMHZyHymFYas0SSO/Wo8BEI3ewB2m7ffh2hTAiReMl+G5q8qFDgFlhtXNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cDxEvR+L; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cDxEvR+L" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48dfdd431dcso1272381f8f.1 for ; Sun, 18 Oct 2026 15:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792362837; x=1792967637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=uPFvsWTFV+hyF+D4UYXzl4VkLEfqeGLRcfL+8XHsGFQ=; b=cDxEvR+Lw7uq5doS3nWqjJZ9RBl+Fiai/Bpx4KdKNsaByaxiABp79VH5h9WKYxlWFn nsoi+DrJay1pGjmC3gaJIqfhddjB40bnXaLF+36Ln4evGQ3hMjmNrvevQ9lYkg2CrIT5 0xcsHoGzWLfJKnl4O56gsF+SWuXEAyTVKuNbYYabrZjkGXHmEGINnXpAxqGXEBHPyi8W s3DmcPaoBeuzquxfoCt5vvre6EU/wcFZrvqT0jLxYAe9K8xygBPnSLyCtBrAb1tcWzJS a2Q5I5LheBTGDBhP1jdUTNNnj6HKoxLs0WkI3oNNyN5d5YzDSjRJPtsEjAC+RpiSfVwQ PP5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792362837; x=1792967637; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uPFvsWTFV+hyF+D4UYXzl4VkLEfqeGLRcfL+8XHsGFQ=; b=RJU6alN/aUNv2RXkMd3782A+/ZFePVQ3LYknulyBG1FgbQ47ik2vkibgKgIvsmSiXX 0Lirx3q2DDI8bDrlfi3bkYbaMqnCr0hfyH90TS9xtF3kRskfJk3vZSpjrRfcZJhJhhJA 9xZ8gfGK9OEUQav0+eUFbaxhT/HcQ7sYI6u3E2bu0DEFiCPu5RrLmeYedU/GIQmUcL9F LOEJcbl1E8DA9S4zewR2df6iggicnTRyV/cuV9fjvkx2frC50FwEHSJopMIdAjR6ziAZ pC9pUDfSkn/VZKGahg5WYjOyLWPr98KUzzYviXE5lMBrpNhE+sUjevFkcalSjXkVx4Md k0IA== X-Forwarded-Encrypted: i=1; AKwUvBwy1Hej643x/VO44jJG0bwl/20X9uvh4winVorzTxlOYUh7WJLZzJxiCWsQw+0HsymHjBBq7D3pFnY=@vger.kernel.org X-Gm-Message-State: AFq9FYK93RO00ULQDh4QgthlHEntDVJfcFbLeeywTtXMKl1K+t4YWZ8S khyzNVMHorRt1/WUGaOw5hR4GA6yDJcnB2L2AVjXRiTVfcR3ezHMlsM= X-Gm-Gg: AYBFou1LDX7I1IK9xBk8NYCeRskZnzbIN1gtm0N+mpNokHsxo8EYktlV4U4vz8cOkxC sCSJI6INS+KfmdScGPSWhl0HR2I0kzkgkIpbMwwne7riWKemFJyWOnvglhNsH9D4LrMEkBJ0mQQ 5IItZToH8JHJ2f0r9HeHd7rTyB08mdvmL/eBa0+MXY2n6qJ2B8kj91wKOdnCZufrCQTc2SDUOlU QmjIFeavfzL6AnlrlHBB+SypVLVnuoVBxgMJLVERPdbOhfjhvSKAVF7S3+2W6CE3okSDUaJjdqN AtsqghmjjZwuhhVRRqzJV3/m5ou6/EgJ4NXjwnHcKds3mHx4irerbZraAATzRX+wE3zt6d5ljcP 7fi8bt91YAMAGst5VbsRwUt5t0Fo4Q0G82zj52okQy8FFl/UuIN5TKb6PVrT201yVVgFjiRGFc8 OYZO9j+i/RZsYt62FSJdjdhQxXwzBB7qrpkIqPXaU= X-Received: by 2002:a05:6000:4b1d:b0:48b:437:8fbb with SMTP id ffacd0b85a97d-48dfae72117mr20868108f8f.19.1792362836691; Sun, 18 Oct 2026 15:33:56 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd510ba3sm19060806f8f.56.2026.10.18.15.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 15:33:54 -0700 (PDT) From: Tristan Madani To: Johan Hovold Cc: Greg Kroah-Hartman , Kevin Lloyd , linux-usb@vger.kernel.org, stable@vger.kernel.org, Tristan Madani Subject: [PATCH] USB: serial: sierra: validate URB length in instat callback Date: Sun, 18 Oct 2026 22:33:52 +0000 Message-ID: <20261018223352.2021650-1-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani sierra_instat_callback() reads one byte past the usb_ctrlrequest header at offset sizeof(struct usb_ctrlrequest) without first checking that urb->actual_length is large enough to contain it. A short USB interrupt transfer could cause an out-of-bounds read. Add a length check matching the pattern already present in the option driver (option_instat_callback), which validates the same field access. Fixes: 033a3fb980b041 ("USB: Sierra Wireless driver update") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- drivers/usb/serial/sierra.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 6e443aacae07d..8f800cde25229 100644 --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c @@ -575,6 +575,11 @@ static void sierra_instat_callback(struct urb *urb) __func__); return; } + if (urb->actual_length < sizeof(*req_pkt) + 1) { + dev_dbg(&port->dev, "%s: short interrupt transfer\n", + __func__); + return; + } if ((req_pkt->bRequestType == 0xA1) && (req_pkt->bRequest == 0x20)) { int old_dcd_state; -- 2.47.3