From: Andreas Kemnade <andreas@kemnade.info>
To: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] usb: ohci-omap: implement overcurrent handling for GPIO-based power control
Date: Tue, 20 Oct 2026 22:23:35 +0200 [thread overview]
Message-ID: <20261020222335.7133c8a2@kemnade.info> (raw)
In-Reply-To: <CAB_t1-ACDiUrXneHbqVy6GWcuCJqnQNdM0poRyrdv_y7G6TKzg@mail.gmail.com>
On Mon, 19 Oct 2026 19:45:15 +0330
Muhammad Mahdi Amirpour <ampr.mhd@gmail.com> wrote:
> I do not have the hardware to test this patch, so I cannot verify it
> at runtime. Given that this is a legacy driver, I am happy to drop
> this patch and work on something else if you think that would be
> better. Otherwise, I can send a v5 addressing the Sashiko bot findings
> (the IRQ handler ordering and the probe falling-edge race).
>
> Please let me know how you would like to proceed.
So this patch practically only used on omap1, it does not improve
maintainability (e.g. by removing the last user of some API) or
apparently not a critical bug. So it should be tested.
It should probably not be first priority to implement something you
cannot test.
@Aaro do you think that improves something valuable?
Regards,
Andreas
next prev parent reply other threads:[~2026-10-20 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 16:15 [PATCH v4] usb: ohci-omap: implement overcurrent handling for GPIO-based power control Muhammad Mahdi Amirpour
2026-10-20 20:23 ` Andreas Kemnade [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-18 22:33 Muhammad Mahdi Amirpour
2026-10-18 22:50 ` sashiko-bot
2026-10-19 6:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020222335.7133c8a2@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=ampr.mhd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox