From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792690359; b=qI6qsfM+xefcdOCb7085dx7Fv1uG1yPAe8r9dEOtFA+ZqPnNfBaURUBijiagEww2AlCJ +a52hKAwx4OS4Z7QqF2ZkoE6is1G7tslFi9yBCq15R0C46v7AGKDsm9r/5XYWKQ31WZhm LluGPdVRwZCfuVLDiThnG7l5nUuXcwNI4hDtTxxxxVf6ymGJDQei9EDYiSjylU9vaVNKt IfUe27Mm9Di4vRp19yUh8+gCtZQX3qRTebs1WNjHmmQpGpSFAEmZNl68lUdSyVGsZPw69 F9BrlBp6cJpz+nqd9MqP7aWppcDjWxEiaXqD6Gd0rKzqLBFMp4Fq2MmKr5gjTPwE+zg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792690359; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=5TTK5L3C72RVXuyCfPoL1KiCUuBlYM9fSsQ+OoWqJh0=; b=KHfzPhAD6E3AnxzxwJzMBaOmnR+be7AiJZ+eCEMx0eJ4SUu1s/5jYT6pDpMx+zZiT9Gq dIPfvAMU9uCJaHOn3KAqlLzqXZyf3s0mniE1PBfBetlYAsImn/AnEJVe6CeZAMIhFHaK2 WQN2fCVKw7n0S36aRn1VpNRRIJ3YW83dRUr3NZ/n4u14NqHvU1Sp4DQCb6o+bFWE9JY75 L2cPbsvpTjw3+fR4n3dtJw6WTYegFlurhtfqRQu/fa4+kQx76p5N7IWgE5FmY+5Kx553X kpd4xdPGaPHhq8WbEnu7np4xPA3Yn6TUE5lTcAkIJlLiOJ4wDDEaQFp4DGesKDWV2Tw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=eeCmVCgM; arc=none smtp.remote-ip=209.85.128.43 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C23B1606A31B for ; Thu, 22 Oct 2026 17:32:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C23B1606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=eeCmVCgM Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a1fe9efc0eso279085e9.2 for ; Thu, 22 Oct 2026 10:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792690357; x=1793295157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5TTK5L3C72RVXuyCfPoL1KiCUuBlYM9fSsQ+OoWqJh0=; b=eeCmVCgMegRCMD7vOlGg+I+VL7pQWFbhxv3PU5KxF6XDa0o7ajmM/7XY1L43p9HS5+ itOL5APh7mnHzuXNFok96uju1BIDvogoYxKs+LNEoP0KzZqKpZB2h4aJiZfAoVBC9rXI OXBa64Ghjhyr3+zpRWSioZQBJ0F4UnFDPvOW8xL1I0c88FZETbuvhll6WKwGvxuDYd/q NjLKXl/YgtmD82fvvGg/sJb4Rb4nlhHaEawHymhU3n5L5dc4+7NXPF/gaQzxtJS1htSz 38lzO8YmLXH2ksX3fpjcSb2gD+VyGT3rVqk4P5zdk3C8pUXkvGTDCmhsvkyUpHkOLD95 0LGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792690357; x=1793295157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5TTK5L3C72RVXuyCfPoL1KiCUuBlYM9fSsQ+OoWqJh0=; b=FksZZRo71IFHNr8s9MgU7BfUlQh5FtcUW21A44K7LwGd2Ko0l85rYRJUB/K/FdBa1l sA9aphSoyOy43uhPUIW9ujsOAn/CMGYVB7PUifhC3QhR6Utp4ZzchJMOAG5neLJ1JJQE 9GWPyDcqnEGOz9GKM1e9jOBpBZ+ic3cVwcTh3vvmoPppAAF0Vv0UJcj1bFlNkhiBX8lh qGgtdE5ck+e+6q8KjWQr7IWsJn3d+gBrAjyZPRezMkP7l7nBVD40zZesbJ2stunhMLzP QiNzwkg4HN6m3Kfx2KCFeHzYZUY9DK+g+SiRLpkfWUjTqQo5ShrqroUebHuhA3dzUhit 2mPA== X-Forwarded-Encrypted: i=1; AKwUvBw+0ogwTUh1BLjIV+a9kCmnTECYL5Z8/LAh99L5ae4hXk5bfxj2O+QkQF3ikO2bjZ9ymM1HKCgMMu4=@vger.kernel.org X-Gm-Message-State: AFq9FYL6EazgjxKxQelmmjniH7ftcz7VxzSXup+CkEYKAJVOB3J+hvtt kRIhPiSOze0Q/h83iIY104xhBR0Ijr3Ejnt5IyTfVAktMfJIi/Aq44PK X-Gm-Gg: AYBFou17bV7liCM2VRWATST2Ijm+fwE2IsjuA6DRnYD+E7K30vhYklui9WsJOrAQ+YR OCfdrZY6AFtcoHARwBZ/HoQAPzD7WnRmhbQmIh48AxUtzBHWzdvoWRThezMoZM4PKXhrjEvKUQ/ GETrp4Z6DNlSUHcsUb4cp1Jhyc4poXP7tiNsi2bwp0hZ9vsZH9nUdACQYFT6GO4JH6RlFY8Ttxl e+MQfNAW12XBPv0PFI86IZmFDc8Sz9ce7ulO87aYKD8kmjYgZDJU3xyvmkFUz3eGKHcW63Q4Z9Q Zb2D1HbG+MpbjbCKrsRFXpUeDUTAN3lpAVtvv3d/bHLtZ+k5XPJExBuOHMCGLyXYmisloMrAdCL TMGXnt7/UsaWxL0V6ci8kjjkRAkRa9ttTh5rifY3TkZp636isEZgaJAmc/HkOTCw4VgI/pKh6KR +yiP+Dd/7XFj44rhkvihHoyGFLq75//Gin9i/SR9Xftxp7YLI3mkwmK2AatHt6Q58KjK4kJiO5P scEag5hPqPqypl8z0IRQgbE4hj/RbHHAmYEyProOquvVBGTJvomLq/CX4X+brmEIJ8tkf22k6uv cOYl+rk= X-Received: by 2002:a05:600c:8b78:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4a20cbec0d1mr26844975e9.23.1792690357003; Thu, 22 Oct 2026 10:32:37 -0700 (PDT) Received: from localhost.localdomain ([188.190.249.216]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e2581f0d4sm13857279f8f.13.2026.10.22.10.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 10:32:36 -0700 (PDT) From: Vladyslav Tymoshchuk To: Bjorn Andersson , Konrad Dybcio Cc: Abel Vesa , Heikki Krogerus , Greg Kroah-Hartman , Sebastian Reichel , Krzysztof Kozlowski , Dmitry Baryshkov , Casey Connolly , Johan Hovold , Jishnu Prakash , Kamal Wadhwa , Joonhoe Kim <26rote@gmail.com>, Daniel J Blueman , Neil Armstrong , Kees Cook , "Gustavo A . R . Silva" , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Vladyslav Tymoshchuk Subject: [RFC PATCH 4/4] power: supply: qcom_battmgr: Allow charger changes to wake up the system Date: Thu, 22 Oct 2026 20:32:24 +0300 Message-ID: <20261022173225.58-1-tvlad744@gmail.com> X-Mailer: git-send-email 2.45.1.windows.1 In-Reply-To: <20261022164151.592-1-tvlad744@gmail.com> References: <20261022164151.592-1-tvlad744@gmail.com> X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The battery manager notifies about changes of the battery state, many of which arrive while the system is asleep, and about changes of the USB and wireless charger properties, a charger being plugged in or out for one. Only the latter can be worth a wakeup, to show the new charging state for example. Make the device wakeup capable, and set a wakeup filter that lets pmic_glink report only the charger notifications as wakeup events. Leave wakeup disabled, so that nothing changes by default: whether a charger change should wake up the system is up to user space, through power/wakeup. Signed-off-by: Vladyslav Tymoshchuk --- I used an AI assistant (Claude) for the analysis and to draft this patch and its description; I reviewed the result. The testing is described in the cover letter. drivers/power/supply/qcom_battmgr.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index 636d6f6acecc..7a783a3a320d 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -1596,6 +1597,20 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr, complete(&battmgr->ack); } +static bool qcom_battmgr_is_charger_notification(const void *data, size_t len, void *priv) +{ + const struct qcom_battmgr_message *msg = data; + unsigned int notification; + + if (le32_to_cpu(msg->hdr.opcode) != BATTMGR_NOTIFICATION || + len != sizeof(msg->hdr) + sizeof(msg->notification)) + return false; + + notification = le32_to_cpu(msg->notification) & 0xff; + + return notification == NOTIF_USB_PROPERTY || notification == NOTIF_WLS_PROPERTY; +} + static void qcom_battmgr_callback(const void *data, size_t len, void *priv) { const struct pmic_glink_hdr *hdr = data; @@ -1750,6 +1765,10 @@ static int qcom_battmgr_probe(struct auxiliary_device *adev, if (IS_ERR(battmgr->client)) return PTR_ERR(battmgr->client); + device_set_wakeup_capable(dev, true); + pmic_glink_client_set_wakeup_filter(battmgr->client, + qcom_battmgr_is_charger_notification); + pmic_glink_client_register(battmgr->client); return 0; -- 2.43.0