From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793055593; b=CXHWUNCuMk848L7qQAxt+2ElDi6IbHrY+/pBWULMW4skutaHY4KgNjEzGADfsZX1gkpT wtDjp+T8EDOE/145N0R13jwtxbo3nLKnJiNnvHYaCV5cQ5OjxTFln0YQn7IxY74tHnS88 WBEkB4sw5R0YRA2Yjc5ORpdM1YR7P3nAbWQC+DUM4o3ibl4qjmUO8wG+VMSpWDNyCpwtc n9PNGh+tJxSClkzr2N2b9REvzqnj/1xh1XdTyfkX226yT+FnWVhzAOIwvnKwOcHgmt4i8 FjXYBwtwDdU9xQL5qsTG4x+MLz+P7nYpXnN82d2VM4lk/77vsPxNFf3oDPYku8dVNwA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793055593; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=xYFlSdYSBy4efBRscq6PIWjy+kL+seLzZByRLeIBFMw=; b=GBsBRYmID/dZ13ZNfMXvyemN1V95kpv7M5wzoFEptNNeheOUL8RZk8y9koP/Yn+nvWKw n9wC1jKXKYeRS3v2eOsp9BXJaQRYbypLF3YBcAaxh2PG5JCaAwx75mFQuIydNm+k7qcIR kMkiscaPFW4vlLvHrxxAhrnlExvDc2XNgoeQ3EsdWX5SvHhRLItCGbLjegPOlExmB3OtV fCIBTHHe38I6ykbG9/XZ02y25G9WBnD6Arsd5kC/6ZEUDEta+wZL6k9m/ETSVH5NsD0d1 uKKWjrbnki4Is8Bmcg6tPVTTetgmDWLNyk2b7LUG2HsovMYbVa60eoW6maxqdstp1RQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=JtgX6t4H; arc=none smtp.remote-ip=209.85.160.180 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11836606A31F for ; Mon, 26 Oct 2026 22:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 11836606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=JtgX6t4H Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-53394bffe0fso3905961cf.1 for ; Mon, 26 Oct 2026 15:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1793055592; x=1793660392; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xYFlSdYSBy4efBRscq6PIWjy+kL+seLzZByRLeIBFMw=; b=JtgX6t4HkHHesY7n2JQPJyp+pm6/msV+LFkLCJeK62zQwbPs2o0eO3GuMpiwLyNqUP WdbCdxG4OXTrmFVlJcvkBmXQ9YK0s18xT86CS06J9aePaF02lGMjkyV+i9+s8AUyZYEo sVBYaHLO/lJaW0Nf3fxwP9S6DP4jpS3e3B7HPfWGx8noGECoZeSPzRqN8XrpE4+O7Hd6 nE+g5KgftytnmNVxGTrNW812PMJZKe7xsMJRVS1IsYJ+7VcaMIV2Aq2Mx2fYBPvmFlNB KVI3wubDsUSR0XMK4VovCsCi/Ayb1GFD6RmHsKOHAd50F1EKGy7VTJQkptwcIKutBLP3 4sVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793055592; x=1793660392; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xYFlSdYSBy4efBRscq6PIWjy+kL+seLzZByRLeIBFMw=; b=2XgmXM+Ue24SdS9C0C4PbfOWkVsN4vjntChGD/g9Q76RUvN0gs8TFErsoxszYpToYG Y14JEr/N96Dwkmr+7kxiA2+8w0G5GEVzExnGA0O44YmDX0THwJHOUqbEGESSsqY6YqPo sH6IsizWUqRsiSb/ld7NFqv1xspMztMdkd021yRc5rxkQ1Lipn5axl/HTfn/lVTbgiZe G4s3gUOyXzMkRLAyWaJvkWJE2mtnDcAVuRY7dtNyhH75vqvTI2Q0DZHRItZFEr6/9LZR Vsfyf1c/OyLSR3y/zLrXwM3mDgOsFlE/7LSFpDf+iwDUGPxOfkySWXqH1YXYFi/NxwsP mRvA== X-Forwarded-Encrypted: i=1; AKwUvBxZ5x/PcSeJvg7RDE7AumNlx3ytQcvva7VHIxACBZ93QX36qd9/xHy2uxG5AJNruUKRQCTynj05jOg=@vger.kernel.org X-Gm-Message-State: AFq9FYID7enEq6i3VeSKPwzCM97+a2Ac6Zo2Mn3JaYGnUk7SZCJKLuIA 86/twFgXz28ycbjqc2GVQghpxsGUHjfszxc/+MbkATFEsqT2EVC6DBfHKY84jzhFn84= X-Gm-Gg: AYBFou2VM/vLBex/Ty3kCy2K+QYnD935DnFfJTJYuCM+yB8vC2k2Ae6aiDj15I3TJT7 QzdwHPk6bPywHEfoiBtwF8HJq79xIma+UNEvxuyz8TZXmubdUxlVzEkwI2n+NQzjBqxnLBEKRXy NT2QPOlt5j45hatj3U4yfSzkua84UlnoSTX3DV5qlfTxfhGBT+z+VJVz1l+CrCiOHEePBSGdpmN jWs5+HVmE5bdJSODyhAEev+F66OO/WuKtmIHGTgbGgDD84JOr4sCRw5OBIv4AON4Zi5Q0AJPFee pp9xUm0oy0TpVThz3PoHBnFQorBDcWmdF+wD+CdUruo1QP/aNJk7dPuWRgvIhJYNf2lf0151rQe nu3kzFluz2NK9h/pNc3G43HHm9cMAUrH9kk26Kf8sVtMmTR2AEdwfNuiZ+2dNHNu4f5LV+bwmsZ MZW75LTjDKaLJoWrgtzfs3f5kA6S9eHmHOalcqHQVrImHHOHQQjlGcuaUBHaLJkDb06zaAxaeP0 qEfz/6quvvnEAkuUpna6Ae0w5F9U9viwQVmQrDmQpUm1s9YEy1nu8RKYhY/hXziYhVPlc0xNgbL 0BiWxe0iHmOkFXF5UfpiM3JSqMz/xNk8hgTihQ== X-Received: by 2002:a05:622a:5c06:b0:536:60a0:5515 with SMTP id d75a77b69052e-53e3f95510fmr21198101cf.17.1793055592065; Mon, 26 Oct 2026 15:59:52 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5383970ac84sm65824991cf.20.2026.10.26.15.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 15:59:51 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xLTfS-000000089Kh-2dEv; Mon, 26 Oct 2026 19:59:50 -0300 Date: Mon, 26 Oct 2026 19:59:50 -0300 From: Jason Gunthorpe To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Greg Kroah-Hartman , Alex Williamson , Armin Wolf , David Lechner , Danilo Krummrich , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Bradley Morgan , Aleksandr Nogikh , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-usb@vger.kernel.org, driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org, Johan Hovold , Richard Weinberger , Thierry Reding Subject: Re: [PATCH v4 0/3] driver core: add TAINT_FORCED_BIND for when userspace manually messes with devices and drivers Message-ID: <20261026225950.GD1685504@ziepe.ca> References: <9bd3a34b-5e98-4038-80d6-da2c3b1948dd@gmx.de> <2026092321-province-yearly-44aa@gregkh> <2026092348-victory-erased-0e5a@gregkh> <20261023181326.0dc2f7ed@shazbot.org> <2026102437-vista-unsoiled-b089@gregkh> X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Oct 25, 2026 at 01:48:04PM +0100, Uwe Kleine-König wrote: > The more I think about this taint, the more I believe the commit should > be reverted and replaced by a some stop gaps for driver_override. (Be it > a taint or better yet > https://lore.kernel.org/all/0f7446324f6a0c8f0153d6532d92a6eeecd6a308.1790612298.git.u.kleine-koenig@baylibre.com/ > .) I also think this patch is way too broad and should be reverted until something better is designed. To me this is very similar to the filesystem issue with syzkaller fuzzing the block device and crashing filesystems. They said filesystems touching untrusted block devices is out of scope. Same here, kernel drivers touching untrusted HW are out of scope, we have never supported that. I think a taint from force binding outside a match entry and using new_id are probably about as far as this idea should go. Even this would still regress most common VFIO instructions though, so some kind of disable for VFIO would be needed. I don't agree with the assertion 'servers are already always tainted' that doesn't match my experience at all. unbind should not taint, we support hotplug, and manually binding an authentic match'd driver should not taint. Jason