From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Yendapally Reddy Dhananjaya Reddy"
<yendapally.reddy@broadcom.com>,
"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/9] dt-bindings: phy: bcm-ns-usb3-phy: Describe the NSP variant
Date: Fri, 30 Oct 2026 13:21:51 -0500 [thread overview]
Message-ID: <20261030182151.GA1206797-robh@kernel.org> (raw)
In-Reply-To: <20261021172819.668120-3-florian.fainelli@broadcom.com>
On Wed, Oct 21, 2026 at 10:28:11AM -0700, Florian Fainelli wrote:
> Northstar Plus uses the Northstar Bx PHY register sequence but also
> requires coordinated USB2 and USB3 core resets and a USB2 IDM interface
> clock enable.
>
> Add an NSP compatible with a required USB2 DMP phandle. Describe the
> shared PHY relationship with EHCI, OHCI and xHCI so initialization
> finishes before any host starts operating.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> .../bindings/phy/bcm-ns-usb3-phy.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> index 7fd419db45d0..00d69b86cbff 100644
> --- a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> @@ -14,6 +14,9 @@ description: |
> Known B1: BCM4707 rev 6
> Known C0: BCM47094 rev 0
>
> + Northstar Plus uses the Bx programming sequence, with coordinated USB2 and
> + USB3 resets. Its PHY is shared by the EHCI, OHCI and xHCI controllers.
> +
> maintainers:
> - Rafał Miłecki <rafal@milecki.pl>
>
> @@ -22,6 +25,7 @@ properties:
> enum:
> - brcm,ns-ax-usb3-phy
> - brcm,ns-bx-usb3-phy
> + - brcm,nsp-usb3-phy
>
> reg:
> description: address of MDIO bus device
> @@ -32,6 +36,13 @@ properties:
> description:
> Phandle to the DMP (Device Management Plugin) syscon
>
> + usb2-dmp-syscon:
brcm,usb2-dmp
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to the USB2 DMP on Northstar Plus, for its interface clock and
> + reset. All USB host controllers must reference this shared PHY so that
> + initialization completes before any of them starts using it.
> +
> "#phy-cells":
> const: 0
>
> @@ -41,6 +52,18 @@ required:
> - usb3-dmp-syscon
> - "#phy-cells"
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + const: brcm,nsp-usb3-phy
> + then:
> + required:
> + - usb2-dmp-syscon
> + else:
> + properties:
> + usb2-dmp-syscon: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-10-30 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 17:28 [PATCH 0/9] Fix USB2 and USB3 on NSP SoCs Florian Fainelli
2026-10-21 17:28 ` [PATCH 2/9] dt-bindings: phy: bcm-ns-usb3-phy: Describe the NSP variant Florian Fainelli
2026-10-30 18:21 ` Rob Herring [this message]
2026-10-30 19:14 ` Florian Fainelli
2026-10-21 17:28 ` [PATCH 3/9] phy: broadcom: ns-usb3: Coordinate NSP USB2 and USB3 initialization Florian Fainelli
2026-10-21 17:28 ` [PATCH 6/9] dt-bindings: usb: generic-ehci: Add the NSP compatible Florian Fainelli
2026-10-30 18:22 ` Rob Herring (Arm)
2026-10-21 17:28 ` [PATCH 7/9] usb: host: ehci-platform: Set the FIFO threshold on NSP Florian Fainelli
2026-10-21 17:28 ` [PATCH 8/9] ARM: dts: broadcom: Identify the NSP EHCI controller Florian Fainelli
2026-10-21 17:28 ` [PATCH 9/9] ARM: dts: broadcom: Use noncoherent USB DMA on BCM958625HR Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030182151.GA1206797-robh@kernel.org \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
--cc=yendapally.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox