Linux USB
 help / color / mirror / Atom feed
From: Jacob Riff <jacob@riff.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] USB/Thunderbolt driver updates for 7.4-rc1
Date: Fri, 30 Oct 2026 20:23:37 -0700	[thread overview]
Message-ID: <20261031032337.37451-1-jacob@riff.dk> (raw)
In-Reply-To: <CAHk-=wjGk9rBTphk1OAwcqGAE1__KJgMr3B-8X4hKFPX8Wm=BQ@mail.gmail.com>

On Fri, 30 Oct 2026 15:28:29 -1000, Linus Torvalds wrote:
> and honestly, this all seems rather excessive. Retry ten times a
> second, for ten seconds? As far as I know, this has never succeeded in
> the history of this laptop, and it has no bad effects apart from the
> silly messages.

Hi Linus,

Sorry about the noise. As written the retry catches every -ENODEV,
including ucsi_register_port() failing on the role switch lookup, which
no retry can change. Fix follows in this thread: it retries only the
PPM-not-ready case, for one second instead of ten, and has been through
six boots on the machine the retry was written for (three hit the race,
all recovered).

As far as I can see, the -ENODEV in your log can only come from the
!CONFIG_USB_ROLE_SWITCH stub of fwnode_usb_role_switch_get(); the real
one returns a switch, NULL or -EPROBE_DEFER. If that is your config,
UCSI has never been able to init there: TYPEC_UCSI builds without
USB_ROLE_SWITCH but then fails on it at probe. That is a separate,
older problem.

Jacob

  reply	other threads:[~2026-10-31  3:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 13:50 [GIT PULL] USB/Thunderbolt driver updates for 7.4-rc1 Greg KH
2026-10-25  1:50 ` pr-tracker-bot
2026-10-31  1:28 ` Linus Torvalds
2026-10-31  3:23   ` Jacob Riff [this message]
2026-10-31  3:24   ` [PATCH] usb: typec: ucsi: retry init only while the PPM is not ready Jacob Riff
2026-10-31  3:36     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261031032337.37451-1-jacob@riff.dk \
    --to=jacob@riff.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox