From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alex <rubin@afternet.org>
Cc: westeri@kernel.org, linux-usb@vger.kernel.org,
Lukas Wunner <lukas@wunner.de>
Subject: Re: thunderbolt: NULL deref in nhi_remove() from pciehp during shutdown (Titan Ridge, ThinkPad P1 Gen 3)
Date: Mon, 9 Nov 2026 11:49:43 +0100 [thread overview]
Message-ID: <20261109104943.GM176724@black.igk.intel.com> (raw)
In-Reply-To: <CADsFipQPdiLag-w56GjdCFgvuUbKhdC4B-2hc9tPUjr31jPiLw@mail.gmail.com>
Hi,
On Fri, Nov 06, 2026 at 07:46:16PM -0800, Alex wrote:
> Hi Mika,
>
> I'm not a kernel developer, so apologies if this isn't the right way to report
> this.
>
> My ThinkPad P1 Gen 3 has been hanging instead of turning off
> for most of this year whenever it powers itself off on a low battery.
> I had an AI assistant (Claude Code) dig into it, and it found what
> looks like a double teardown of the Thunderbolt NHI during shutdown.
> The info dump below and a suggested patch are AI-generated, so please treat
> them that way.
>
> I applied the patch and it fixed the problem, and it looks like from research
> that this issue was called out as a bit of a concern when it was comitted back
> in the day, so thought I would share in case you want to fix it.
>
> Thanks,
> -Alex
>
> ------
>
> Hardware: ThinkPad P1 Gen 3 (20TH0037US), BIOS N2VET36W (1.21)
> 2021-12-27, Titan Ridge JHL7540 behind root port 00:1c.0 (pciehp,
> HotPlug+ Surprise+). Firmware connection manager. Ubuntu 24.04, kernel
> 6.8.0-138 at the time of this dump. The nvidia and ZFS modules are
> loaded, hence the taint.
Can you try with a newer kernel and see if the problem still happens?
Something like v7.3 would be good. If it does then please provide dump.
parent reply other threads:[~2026-11-09 10:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CADsFipQPdiLag-w56GjdCFgvuUbKhdC4B-2hc9tPUjr31jPiLw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109104943.GM176724@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rubin@afternet.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox