Linux USB
 help / color / mirror / Atom feed
From: Joonhoe Kim <26rote@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: sashiko-bot@kernel.org, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH RESEND] usb: dwc3: tell xHCI that it lost its state when the core is powered off
Date: Thu, 12 Nov 2026 23:15:24 +0900	[thread overview]
Message-ID: <20261112141524.112-1-26rote@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-211064@kernel.org>

On Thu, 12 Nov 2026 12:00:08 +0000, sashiko-bot@kernel.org wrote:
> [Severity: Medium]
> Does the DWC3_GCTL_PRTCAP_OTG case in dwc3_suspend_common() also need to
> set dwc->xhci_power_lost?
[...]
> [Severity: High]
> This problem wasn't introduced by this patch, but in OTG host mode
> does dwc3_suspend_common() power off the core via
> dwc3_core_exit() without telling xhci-plat that power was lost?

Yes, both are the same gap. The OTG case always powers the core off for
system suspend, so v2 sets the flag there too when the host role is
active. OTG mode is not tested; this board switches roles through
usb-role-switch and never runs in DWC3_GCTL_PRTCAP_OTG.

> [Severity: Medium]
> Can dwc->xhci_power_lost remain 1 after resume and cause an unnecessary
> xHCI reset on a later aborted suspend?

Yes. v2 clears the flag in the resume quirk once xhci-plat has read it.

v2: https://lore.kernel.org/all/20261112141512.1840-1-26rote@gmail.com/

Thanks,
Joonhoe Kim

      reply	other threads:[~2026-11-12 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 11:40 [PATCH RESEND] usb: dwc3: tell xHCI that it lost its state when the core is powered off Joonhoe Kim
2026-11-12 12:00 ` sashiko-bot
2026-11-12 14:15   ` Joonhoe Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112141524.112-1-26rote@gmail.com \
    --to=26rote@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox