From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794835249; b=tQOaPZRey4LYVFBZFDl9egDZNYD3rHAknbNVrjLSt0mSKERH+ZMeYqugGTxXLmMLi+So B9rSvxD2sq08q2Mk8P+lsnjh+cO/UZdHP1HnJfV9XhnLrx9x9bHkuY6llZuoq+w30UNoX d5qv8pjqltrLUbwizqF/6DD4qTCnI4REBW//JHevzvkA0pToj75ETMO00SOCtqq+3mVaO 8s4iSYQvHfUrOQppRJXMpCG28izmIzRhtyUdczNyVV0fOyGbtpoo3qeNGhpCAP5VYei8I Iy2G1RAUJ0E7imS5qDFJltO+MnOFhOqncfvfYYkZNJDk/yqSYp1IEC2yeISUtUeFwRQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794835249; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=Obo1LMMcqAVL3fcolmDv/HOQ7RWoUs+0s/WgihdCTs3NKekDdpw0CTl4TXoTxapR6pQC cUa6qsOhaLYKH8f1lrbdCqQIov5jxPuEa804UrmzU5j6GaQ1hYgAzT+ma2v4zbEhUNIVS w7g2whnF38i25b/RuWoAe2hxVubzJxvKhB0pd6EXWQRwto/c+l3GUg698MNI5GJtWe04b Nh+Bm+GaE3bskXu5bih0NVLm9egptLlQ4MjZldObPZZLz0JAXWFkJsdbhphTg3P4zoYEB uzsijnSSKoeS/DZdM1umvUeXcTj+SUtDdEkozdODE9pNiosF8lIxRRxlAScZ/5C6tYA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h; arc=none smtp.remote-ip=209.85.219.50 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435E3606A330 for ; Mon, 16 Nov 2026 13:20:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 435E3606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-91f1e3dd08cso13821746d6.3 for ; Mon, 16 Nov 2026 05:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794835248; x=1795440048; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=F00eXo5hK7MhiGIzcy2xEZvXaOlU++0SsxWdg8F2eYgLj0IP/wqxNHSj70WYC1UCbD vmKPyn8zqLHpLHOvxkTPyXLn/laMAvSaSbXM05SN4tjv6Cx+GcVaR0GxUXpMgXzGykx3 FokKvpAfMx6w/qg4Q5h79shuv6MexzGsY/vmut+9b8A8pQsaE0GfSqy0kYc2aGWEaEae 3xYzyobXgBsc03sh3wdT6H/0kLtFYOlPUaVehm8clJUf4d9zj9Hfn5kvjyTiGQDD3sEC 6wk4kHeXw7a4jDhfFMIm7aNEb1ZQhwAt5xztT2KrBS1HRA1ERCFKDcAKt5g1NH70HZ/q daJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794835248; x=1795440048; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=ql1vfi5opU6rOnWKkOhqz2Dt3QyN2fLFcWMdwH3b1kMMUtf+89xjBI0xj2kGp9HphX kZjLVguwrLlndsH8FYyQSjijdKQa+s93JIEczwPO/xekukHG0ARwHnSUNJbENK4kxIWR T6KB2r0moTmi7CBDmiL/dD287ux6QP2/zA+LX/iauAULWHfvzpJmi2fmoY+riNeuJxGm Rm4J69DU4u3Ek3SvC47kMxmuuV7tq3R6UTCcLPPyQCOJ8C/vo4nKJHkwlBaJEP6WtTI+ 7Bxwl82n4js/t8oAy7Q+v8ASqhSJ9RzPgFzeigyMy64ihtb9j49KrDQvTZC2rZiJeBKE FbvA== X-Forwarded-Encrypted: i=1; AL+hErF/L3IX6rvXqXeBn33vjDGxShpyu+ROEq4FNyXko2n+zEy7jwEY94DeK3BrFhyekK7jsEVBhfwh9Rs=@vger.kernel.org X-Gm-Message-State: APuU4Z/j/P+BPmJhFuhxpfkMCLUKKYA4UY2rcECN9pT81QGjCv8FRxKI AyIZ0IT6yZH1yMe6Gd8e7m90+/1RXJCUClQSqnAGBwOttHowTpSnKBq0Ki6cfBrggz0= X-Gm-Gg: AZFdTZesBY0iXFAZBqyIrA8xQJsx+gLjzIQtDoT/9TnWD/JOi6dlXLsjaJnJdfxZqAw YouKqsF00EhY+jQj1/9IE+szfDQWtdkfUGPBMrFjJyBk4TXtIwC5jThxaP4KFhkpbVYhZrzUohJ lOgBL5CixLlwY9iXYOGMCO1It6C9eYk2fM4EQCU4ukFGNawkR9Ij3srt9AIAinMEWFIQzYH/3gI H1P+OhOiEf5nosrUzB5xMpInjnFs2fw0IRFCWlI++Qlg0WjxMIWSgrjo10TW/V4yjhXXmoVcUAB OrysWr0/6lA0OgdASgDbqUSFg03thLR77LutsY5D8nE8X7mY1iUDKNOZInGSJUtscNpC8y6QOnz 1mfVz3hVE2i3au81FWe7W5fZ0Tep/lKGwCmBLckMNu3g/NHE2eP18dH9/Fzh1UxgrkGxU24UNH+ J+dVZpPlIPdlHzirGYcLie65Q+mpck+OGpSi939hvHoWm02TmOyQrug8eYlN3/CPP3GPCRWPlzQ aIyoPYB3LEkbCZdVK65osU31Qr5HPC7wL7PWwS2DXFotDk/U2gWRPn+RgUSwdfFzZoq3Jey7dvP 0JTrxQ== X-Received: by 2002:ad4:5744:0:b0:91f:3230:2a4 with SMTP id 6a1803df08f44-91f32300351mr126741416d6.53.1794835247815; Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91f23d7ba48sm85758876d6.28.2026.11.16.05.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xSwda-00000009KhK-1awf; Mon, 16 Nov 2026 09:20:46 -0400 Date: Mon, 16 Nov 2026 09:20:46 -0400 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH 17/17] PCI: Replace untrusted state with device trust Message-ID: <20261116132046.GI2532299@ziepe.ca> References: <20261105-device-trust-core-v1-0-1e536825b4eb@nvidia.com> <20261105-device-trust-core-v1-17-1e536825b4eb@nvidia.com> X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 06:38:25PM +0530, Aneesh Kumar K.V wrote: > > +static inline bool > > +pci_dev_default_is_restricted(const struct pci_dev *pdev) > > +{ > > + enum device_trust_policy policy = READ_ONCE(pdev->dev.trust_policy); > > + > > + return policy == DEVICE_TRUST_POLICY_DISABLED || > > + policy == DEVICE_TRUST_POLICY_ADVERSARY; > > +} > > + > > Could you clarify how this series will work alongside device acceptance > and private-memory access? > > In particular, what should callers of device_cc_accepted() use under > this model? Who is calling device_cc_accepted? I thought we were keeping that internal to the DMA PI? > My understanding is that trust describes the operating > policy, not TDISP acceptance or DMA access to private memory. Right. > Therefore, > neither FULL nor ADVERSARY alone indicates whether a device can access > private memory? Right. Once you turn on TDISP you effectively activate DMA, just like turning on the IOMMU. Userspace then gets to choose how the rest of the system behavess. You can still run a strict viommu with an adversarial driver even if you enabled TDISP and can DMA to all memory. I don't know if many people would choose that combination, but it is there. > You also mention that once a trust level other than DISABLED is set, it > cannot be changed during the device's lifetime. If a device initially > operates in ADVERSARY mode and later attestation justifies FULL > operation, is that transition intentionally unsupported for the existing > device object? As documented, unbind/rebind and reset preserve the > committed level. I think it should only be for the duration of a bound driver? > It would help to describe how the trust framework fits together with > those separate mechanisms, including which pieces are left for follow-up > series. The main thing it brings is the pause to allow userspace to measure the device and put it into RUN if it so chooses before any driver is bound. It doesn't change how any of the DMA or TDSIP flows work. Jason