Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: r8a66597-hcd: Fix clock leak and unchecked clk_prepare_enable()
Date: Mon, 16 Nov 2026 10:34:15 +0100	[thread overview]
Message-ID: <2026111648-landfill-skeleton-efe7@gregkh> (raw)
In-Reply-To: <20261116031043.505-1-laixiangwu@cmss.chinamobile.com>

On Mon, Nov 16, 2026 at 11:10:43AM +0800, Xiangwu Lai wrote:
> Hi,
> 
> gentle ping for:
> 
>   usb: r8a66597-hcd: Fix clock leak and unchecked clk_prepare_enable()
>   https://lore.kernel.org/all/20261102100455.600-1-laixiangwu@cmss.chinamobile.com/
> 
> On on-chip configurations r8a66597_clock_enable() ignores the return
> value of clk_prepare_enable(), and if the subsequent register access
> times out the function returns -ENXIO without disabling the clock
> again.  The patch checks the return value and disables the clock on
> the error path.

And are you hitting this in a real system, or is this just a theoretical
issue?

thanks,

greg k-h

      reply	other threads:[~2026-11-16  9:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 10:04 [PATCH] usb: r8a66597-hcd: Fix clock leak and unchecked clk_prepare_enable() Xiangwu Lai
2026-11-02 10:11 ` sashiko-bot
2026-11-16  3:10 ` Xiangwu Lai
2026-11-16  9:34   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026111648-landfill-skeleton-efe7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=laixiangwu@cmss.chinamobile.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox