From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794943999; b=CydaH91Bh5wrqiu8mdSbbHzGeBpwHLoqVFnUI6hpT9gmQDz4xCxfNYL/iHrEYiQ1hi8I TkVy3h4KxB3zVRo9mLJDSw+VgczUzETdemFzx+FZ1Noa876axCX52pqEU5JC9G7WoPbo9 /iGV1jtPTwQzLmHcumdxOR8+1pxKw8oiSTZG76AeRl8Cy0YLSkElC07dgxPN416pUtnZB Apc56GnFksGE7Upe3VLpPIlDEq4+123xT0Www3fDZassTY3qV/ZKfNTDUClEhqTq2J+tB c0oyCjC2WwnAG+bOKRDeRI5YeelQjzFaOUFXdXLKyrofZXM036Fi3K6TbULEEqarZPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794943999; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=iZlOAQRkN5G2+tOZzeiNY9AHm7pHtMPCmdAEzClHGyQ=; b=GtWqZq5aJ8zEPeSCryqtfoUdBtr9LXHrEBUKMw+V/vDwh8PRWiKtRIGRCRnHYVc0muqe YcfmkhI98TtHHDS1A2KYkXzBmFH4VVRXic41g1oFTf5Rg3+bPMK3gDW3FShbntVGcTHdc NUmWbXUbjGup2CHgbEUVh5pN0W0a7zMECZ6d5rm0o5sk57lXEU6JUMThyTQbnAM4ZaMWV 12/Roxu+aONR/iZu2aegyMc9sV+DIGNhotYiPl2zeiz3wHqA2IwYVmUp9ozpv0kSnhHqk NJqqgHQQZQf0yFJCUrrnX/E/L1jEasNAUQyK9Iwl949ctqo4RiTATAJVQyvIIpMFTYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L8YPwaBe; arc=none smtp.remote-ip=209.85.216.41 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FF4606A334 for ; Tue, 17 Nov 2026 19:33:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B4FF4606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L8YPwaBe Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3acb11973c3so56044a91.3 for ; Tue, 17 Nov 2026 11:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794943998; x=1795548798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iZlOAQRkN5G2+tOZzeiNY9AHm7pHtMPCmdAEzClHGyQ=; b=L8YPwaBe5vXOgdwYhFGtgeWAt5sTw9fVNeZFWBpGg9dZJDIOEUnpY/KvST5P1iDbIE LxHY4rsA5h2UTiUCcNHm0VxKEiMQKYkHu7Ld5wEMqFgvnz0j95dY9qTebLkhplufnZ1n FJeI3dm556n3zshgIFGAv7YJODx/MSs3tNLEAW0GuixCVfZjTMC7rkqCDH5YaLTKW8Gl CWYPDtw76QyjqOXxTpVQ+gu06WAuMNwT53aE+SNPTB7kgAISXubNvgxaSeTFFGvwfCa/ dlHPaaAtzhJUn363UBoiUmsJzuqxsogFMPukQNzHvWTvZvIaxupR+kAdQM3ZRUkketSY M4og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794943998; x=1795548798; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iZlOAQRkN5G2+tOZzeiNY9AHm7pHtMPCmdAEzClHGyQ=; b=DY7KxUJTSvMvxfixtbXVdUXBc1rb0AzKYkcPJvkLjhJofgTJPjAOC2h+W9+xSJq9Mj uWTpbnsU7PGd8M0xG6RiZBp73cqro+kHzG+QRXTWNGPJhLheTKq5ZF+UfcaUpnANSYlK aRMAQa/Rs4viHBaaZwXGkL1AVYfDDeS+vWoJN4n99h0qLp9fYcMGgDrw08zXNJlcC0PT R/NmzgI0Ns/prPZ5ADd1ySAvE3S1ZY+YWA2saf1gkAVAqdasGw7WVOJp5ZsvSVTAdqRc ZIPfMaqdITWwIyddBzamEcsnxnvkB+EG4Jx/qD7nNzrCfO28ubHxrzUZj2lOOOPtb8Cj OvJg== X-Forwarded-Encrypted: i=1; AL+hErEgt5ZDJIulXXsXop97sqZtRq/rKodz+uKVhRlqb62nequnJrk/y02y5IXmMAMdydL+tA9IpWxTjSE=@vger.kernel.org X-Gm-Message-State: APuU4Z9EXl02tWxAFpgxO95phXYRyFcSYpQR5ulAazDEdJ62hZdO6TPK NfpYKGG3Xl1Pp1caB/vZFiSxrIiVipwdQcyzyyipIdLQLFMQqk+vjnOJS0awYS3q X-Gm-Gg: AZFdTZeE5U5KRESMqIfriMQDqi3Tjgv//yIbJ4z7B2VHR5WnZsygkIRIPMovkxChCM1 3KslE+wi0JEsnTCRWkkuMk160HYYkM+kTf4AW3XvWrlc+gmB1Si9K9PAqTwfI+IERKdmGILnLCL rXNuPvPnuadDgCtVMibwyy1KntGOiUJIKB3E8714FVRYk2u9Y16wYDmW/jZv8YDwxdmGkxU6gQW cIpSRbJrkkCydFO5XqfJ7OjGf2TQrRe6KGiOzXDE440YS9WHwWhPP60Aj6ZMMWO5zi44/MxgfLm siuXL/4Ysbm98McRbhELrhhSdo1RgC3fBmrQKmkhELNrdiQy2yfvDC9a9XVStHq9VmLxReDNtVf SEMuzqW+PysZX7o/ECgNllWjFx2dbSiCZ9kC0a7wVzRcgRk+5Xj4ZNcVOmmaA5hscBOQ3W2h2pZ 32Ri7YAT6K4MbLJMX9tJPszvgYPIBZf5UlkTlRpEB+YRFIgh31nY5t7PFtCeWNXEYvMa+jtObTh tv8eqN7Jc8QqMHYNW7f/MrFpPjp4Bfnh8l2oHHpr9A7Ka4/sMq7d6HEsP93Pvr+Ld4K+SFWqt99 dvVU+D+9SGIKGGDDAJvm1IZVJ1jceuxi72O7h7FQyELDzQaz+IykdSk= X-Received: by 2002:a17:90b:48:b0:3ac:86a0:5766 with SMTP id 98e67ed59e1d1-3b3d07d29e9mr369689a91.63.1794943997974; Tue, 17 Nov 2026 11:33:17 -0800 (PST) Received: from r-desktop.tail1ce325.ts.net ([2601:600:cb87:4c27::6a99]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b3d19b6e18sm359163a91.10.2026.11.17.11.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 11:33:17 -0800 (PST) From: Riley Wagner To: mathias.nyman@intel.com, linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, Riley Wagner , stable@vger.kernel.org Subject: [PATCH] usb: xhci: pci: do not perform Soft Retry on AMD 500 series chipset host Date: Tue, 17 Nov 2026 11:33:00 -0800 Message-ID: <20261117193300.25897-1-riwiwa00@gmail.com> X-Mailer: git-send-email 2.56.0 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Full-speed HID devices hot-plugged into a root port of the AMD 500 series chipset xHCI host (1022:43ee) enumerate and bind, but never deliver any input. The device then resets itself after ~10 seconds, re-enumerates, and the cycle repeats. Devices present at boot are not affected. With xhci_hcd dynamic debug enabled, the first poll of the interrupt IN endpoint fails with a transaction error, the driver performs a Soft Retry, and the endpoint never completes another transfer: [ 6658.313453] xhci_hcd 0000:02:00.0: Successful Endpoint Configure command [ 6658.352348] input: ELECOM TrackBall Mouse HUGE TrackBall as ... [ 6659.424165] xhci_hcd 0000:02:00.0: Transfer error for slot 29 ep 2 on endpoint [ 6659.424170] xhci_hcd 0000:02:00.0: Soft-reset ep 2, slot 29 [ 6659.424290] xhci_hcd 0000:02:00.0: Ignoring reset ep completion code of 1 [ 6667.989369] usb 1-9: USB disconnect, device number 30 usbmon shows the interrupt URB submitted at enumeration and only given back by the disconnect, 9.6 seconds later: 2562187476 S Ii:1:030:1 -115:1 8 < 2571824873 C Ii:1:030:1 -108:1 0 No further transfer events or errors are reported for the endpoint after the soft reset completes and the doorbell is rung, so the TD is never retried or failed. This matches commit a4a251f8c235 ("usb: xhci: do not perform Soft Retry for some xHCI hosts"), which disabled Soft Retry on the AMD Promontory A hosts (43b9, 43bb) for the same class of failure. Booting with xhci_hcd.quirks=0x10000000000 (XHCI_NO_SOFT_RETRY) makes the device work reliably after hot-plug on the chipset root ports tested (1-3, 1-9); the same device also works after hot-plug on the CPU's xHCI host (1022:149c) without the quirk. Tested on an ASUS ROG STRIX B550-F GAMING (BIOS 3621) with an ELECOM HUGE trackball (056e:010c) and a PFU HHKB Professional HYBRID Type-S (04fe:0021), on 7.3.4 with commit 6895dbdc19d9 ("xhci: give back TDs and clean up ep0 after disconnect") applied. The trackball showed the same behaviour on 7.2.x. Add the AMD 500 series chipset xHCI to the hosts that do not perform Soft Retry. Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors") Link: https://bugzilla.kernel.org/show_bug.cgi?id=202541 Cc: stable@vger.kernel.org Signed-off-by: Riley Wagner --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -88,6 +88,7 @@ #define PCI_DEVICE_ID_AMD_PROMONTORYA_3 0x43ba #define PCI_DEVICE_ID_AMD_PROMONTORYA_2 0x43bb #define PCI_DEVICE_ID_AMD_PROMONTORYA_1 0x43bc +#define PCI_DEVICE_ID_AMD_500_SERIES_XHCI 0x43ee #define PCI_DEVICE_ID_ATI_NAVI10_7316_XHCI 0x7316 @@ -493,7 +494,8 @@ if (pdev->vendor == PCI_VENDOR_ID_AMD && (pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_2 || - pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4)) + pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4 || + pdev->device == PCI_DEVICE_ID_AMD_500_SERIES_XHCI)) xhci->quirks |= XHCI_NO_SOFT_RETRY; if (pdev->vendor == PCI_VENDOR_ID_ZHAOXIN) { -- 2.56.0