Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: Kevin Cernekee <cernekee@gmail.com>,
	Neill Kapron <nkapron@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: bcm63xx: Propagate iudma_init() error code
Date: Tue, 17 Nov 2026 06:26:52 +0100	[thread overview]
Message-ID: <2026111742-worrisome-twiddle-809b@gregkh> (raw)
In-Reply-To: <20261117011400.1676-1-laixiangwu@cmss.chinamobile.com>

On Tue, Nov 17, 2026 at 09:14:00AM +0800, Xiangwu Lai wrote:
> Hi,
> 
> gentle ping for:
> 
>   usb: gadget: udc: bcm63xx: Propagate iudma_init() error code
>   https://lore.kernel.org/all/20261103014457.1255-1-laixiangwu@cmss.chinamobile.com/
> 
> bcm63xx_init_udc_hw() calls iudma_init() and stores the return code,
> but then returns 0 unconditionally.  When iudma_init() fails the
> hardware has already been torn down, yet the probe believes the
> initialization succeeded and registers a gadget controller with
> non-functional IUDMA channels.  The patch propagates the error.
> 
> Is there anything blocking this patch, or does it just need more
> time?

Has it been tested on real hardware?

      reply	other threads:[~2026-11-17  5:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  1:44 [PATCH] usb: gadget: udc: bcm63xx: Propagate iudma_init() error code Xiangwu Lai
2026-11-03  1:50 ` sashiko-bot
2026-11-17  1:14 ` Xiangwu Lai
2026-11-17  5:26   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026111742-worrisome-twiddle-809b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cernekee@gmail.com \
    --cc=laixiangwu@cmss.chinamobile.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkapron@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox