Linux USB
 help / color / mirror / Atom feed
From: Alexandre Becholey <alex@becholey.ch>
To: Oliver Neukum <oliver@neukum.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alexandre Becholey <alex@becholey.ch>,
	stable@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH] usb: image: microtek: don't receive REQUEST SENSE data into sense_buffer
Date: Thu, 19 Nov 2026 08:45:44 +0000	[thread overview]
Message-ID: <20261119084526.535901-1-alex@becholey.ch> (raw)

mts_command_done() receives the data phase of a REQUEST SENSE into
srb->sense_buffer (SCSI_SENSE_BUFFERSIZE, 96 bytes), but with the
length of the command's own data buffer. A REQUEST SENSE sent through
SG_IO, allowed on a read-only /dev/sgN without any capability, can have
a much larger buffer (252 bytes with sg_requests), and a device that
returns that much writes past the end of the sense buffer.

The special case is not needed: for the error handler's own REQUEST
SENSE, scsi_eh_prep_cmnd() already points the data buffer at
sense_buffer with at most SCSI_SENSE_BUFFERSIZE. Handle REQUEST SENSE
like every other data-in command.

The bug was found, and the reproducer and this fix were written, by AI
agents (Claude Mythos and Claude Opus models). The analysis and the
patch were reviewed by a human.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Alexandre Becholey <alex@becholey.ch>
---
An emulated ScanMaker X6 answering a 252-byte SG_IO REQUEST SENSE with
252 bytes triggers it (KASAN in dummy_timer, the HCD's copy into the
URB buffer; slub_debug redzone report with xHCI), on v7.3.1 and master
9d66f26fefac. No reports with the fix. User-space REQUEST SENSE now gets
the sense data in its own buffer; the error handler's REQUEST SENSE
returns the same data as before. Not tested on real hardware.
Reproducer available on request.

 drivers/usb/image/microtek.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
index 1f0b3c44d388..0b8d7f71c3c9 100644
--- a/drivers/usb/image/microtek.c
+++ b/drivers/usb/image/microtek.c
@@ -445,22 +445,15 @@ static void mts_command_done( struct urb *transfer )
 		return;
 	}
 
-	if (context->srb->cmnd[0] == REQUEST_SENSE) {
+	if (context->data) {
 		mts_int_submit_urb(transfer,
 				   context->data_pipe,
-				   context->srb->sense_buffer,
+				   context->data,
 				   context->data_length,
-				   mts_data_done);
-	} else { if ( context->data ) {
-			mts_int_submit_urb(transfer,
-					   context->data_pipe,
-					   context->data,
-					   context->data_length,
-					   scsi_sg_count(context->srb) > 1 ?
-					           mts_do_sg : mts_data_done);
-		} else {
-			mts_get_status(transfer);
-		}
+				   scsi_sg_count(context->srb) > 1 ?
+				   mts_do_sg : mts_data_done);
+	} else {
+		mts_get_status(transfer);
 	}
 }
 
-- 
2.53.0



             reply	other threads:[~2026-11-19  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:45 Alexandre Becholey [this message]
2026-11-19  8:49 ` [PATCH] usb: image: microtek: don't receive REQUEST SENSE data into sense_buffer sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119084526.535901-1-alex@becholey.ch \
    --to=alex@becholey.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox