Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Boyan Liu <yymhvert@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	co+02480a85e1a0d4f5@bugs.sh
Subject: Re: [PATCH] usb: gadget: f_ncm: Fix use-after-free in ncm_wrap_ntb()
Date: Fri, 20 Nov 2026 13:42:25 +0100	[thread overview]
Message-ID: <2026112019-mobster-coerce-8608@gregkh> (raw)
In-Reply-To: <20261106070914.3637-1-yymhvert@gmail.com>

On Fri, Nov 06, 2026 at 03:09:14PM +0800, Boyan Liu wrote:
> Hi Greg,
> 
> I wanted to follow up on this fix. The use-after-free addressed by v1
> is independent of the two pre-existing issues raised by Sashiko.
> 
> For the skb2 leak in the same err: path, would you prefer that I fold
> 
> 	if (skb2)
> 		dev_kfree_skb_any(skb2);
> 
> into a v2 of this patch, or keep it as a separate follow-up? My plan
> for the independent ncm->netdev NULL-dereference race is to handle it
> separately.
> 
> Is the use-after-free fix otherwise acceptable, or are any other
> changes needed?

I see no context here at all.

      reply	other threads:[~2026-11-20 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  2:45 [PATCH] usb: gadget: f_ncm: Fix use-after-free in ncm_wrap_ntb() Boyan Liu
2026-10-15  3:00 ` sashiko-bot
2026-10-22 14:08   ` Boyan Liu
2026-11-06  7:09 ` Boyan Liu
2026-11-20 12:42   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112019-mobster-coerce-8608@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=co+02480a85e1a0d4f5@bugs.sh \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=yymhvert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox