Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Palla Raghunath <raghunathpalla.0209@gmail.com>
Cc: linux-usb@vger.kernel.org, "Neill Kapron" <nkapron@google.com>,
	"Michał Nazarewicz" <mina86@mina86.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Brigham Campbell" <me@brighamcampbell.com>,
	linux-kernel-mentees@lists.linux.dev,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: gadget: f_fs: fix use-after-free of ffs_dev in ffs_free_inst()
Date: Fri, 20 Nov 2026 11:18:08 +0100	[thread overview]
Message-ID: <2026112029-depletion-small-f290@gregkh> (raw)
In-Reply-To: <20261006204202.59604-1-raghunathpalla.0209@gmail.com>

On Tue, Oct 06, 2026 at 09:42:02PM +0100, Palla Raghunath wrote:
> When a function instance is removed through configfs, ffs_free_inst()
> first calls ffs_release_dev(), which takes ffs_dev_lock, detaches the
> dev from its mount and drops the lock again. Only then does it retake
> the lock and free the dev with _ffs_free_dev().
> 
> Between those two steps the dev is still on the ffs_devices list. If
> someone mounts functionfs with the same instance name right then,
> ffs_acquire_dev() finds the dev, marks it mounted and points the new
> ffs_data at it. The dev is freed a moment later, and when that mount
> is torn down, ffs_closed() writes to freed memory. syzbot hit this:
> 
>   BUG: KASAN: slab-use-after-free in ffs_closed drivers/usb/gadget/function/f_fs.c:4427 [inline]
>   BUG: KASAN: slab-use-after-free in ffs_data_clear+0x543/0x5b0 drivers/usb/gadget/function/f_fs.c:2305
>   Write of size 1 at addr ffff8880237b1e4a by task syz-executor/11910
>   Call Trace:
>    ffs_closed drivers/usb/gadget/function/f_fs.c:4427 [inline]
>    ffs_data_clear+0x543/0x5b0 drivers/usb/gadget/function/f_fs.c:2305
>    ffs_data_reset drivers/usb/gadget/function/f_fs.c:2336 [inline]
>    ffs_fs_kill_sb+0x84/0x370 drivers/usb/gadget/function/f_fs.c:2180
>    deactivate_locked_super+0xbe/0x110 fs/super.c:586
>    cleanup_mnt+0x3d3/0x460 fs/namespace.c:1329
>   ...
>   Freed by task 17408:
>    kfree+0x1c5/0x650 mm/slub.c:6923
>    _ffs_free_dev drivers/usb/gadget/function/f_fs.c:4336 [inline]
>    ffs_free_inst+0x233/0x2c0 drivers/usb/gadget/function/f_fs.c:4152
>    usb_put_function_instance+0x95/0xc0 drivers/usb/gadget/functions.c:77
>    config_item_release+0x13a/0x2d0 fs/configfs/item.c:137
>    configfs_rmdir+0x885/0x950 fs/configfs/dir.c:1580
> 
> Fix it by doing the release and the free while holding the lock once.
> To allow that, move the body of ffs_release_dev() into a new
> _ffs_release_dev() that expects the lock to be held already, and keep
> ffs_release_dev() as a wrapper for ffs_data_put(). A racing mount now
> either gets the dev before ffs_free_inst() runs, in which case the
> release clears its pointer, or doesn't find the dev at all.
> 
> I was able to reproduce this in QEMU with a small program that keeps
> creating and removing an ffs function directory in configfs while a
> second thread mounts and unmounts functionfs with the same name. On an
> unpatched kernel it hit the same KASAN report within about ten
> minutes. With this patch applied, the same program ran for 30 minutes
> without any problem.
> 
> Fixes: ecfbd7b9054b ("usb: gadget: f_fs: Fix setting of device and driver data cross-references")
> Cc: stable@vger.kernel.org
> Reported-by: syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6227549bd2c8a1ec8ba0
> Signed-off-by: Palla Raghunath <raghunathpalla.0209@gmail.com>
> ---
>  drivers/usb/gadget/function/f_fs.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index c64a268e98a4..f8ea9a980605 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -288,6 +288,7 @@ static struct ffs_dev *_ffs_find_dev(const char *name);
>  static struct ffs_dev *_ffs_alloc_dev(void);
>  static void _ffs_free_dev(struct ffs_dev *dev);
>  static int ffs_acquire_dev(const char *dev_name, struct ffs_data *ffs_data);
> +static void _ffs_release_dev(struct ffs_dev *ffs_dev);

> -static void ffs_release_dev(struct ffs_dev *ffs_dev)
> +/*
> + * Same as ffs_release_dev(), for callers that already hold ffs_dev_lock.
> + */
> +static void _ffs_release_dev(struct ffs_dev *ffs_dev)

Then enforce the lock being held here by telling the compiler that it
must be held.

thanks,

greg k-h

      parent reply	other threads:[~2026-11-20 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 20:42 [PATCH] usb: gadget: f_fs: fix use-after-free of ffs_dev in ffs_free_inst() Palla Raghunath
2026-10-06 20:49 ` sashiko-bot
2026-10-11 23:12 ` Michał Nazarewicz
2026-11-20 10:18 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112029-depletion-small-f290@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=mina86@mina86.com \
    --cc=nkapron@google.com \
    --cc=raghunathpalla.0209@gmail.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox