Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joshua Crofts <crofts@kernel.org>
Cc: "Bin Liu" <b-liu@ti.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Felipe Balbi" <balbi@ti.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] usb: musb: fix use-after-free in musb_remove()
Date: Fri, 20 Nov 2026 15:11:06 +0100	[thread overview]
Message-ID: <2026112054-sweep-flap-b94d@gregkh> (raw)
In-Reply-To: <20261107-usb-uaf-fix-v1-1-ba33689d0ca3@kernel.org>

On Sat, Nov 07, 2026 at 12:46:17PM +0100, Joshua Crofts wrote:
> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
> before usb_phy_shutdown() is called, causing a use-after-free bug.
> 
> Reorder the function so that usb_phy_shutdown() is called before
> musb_platform_exit(), the same way as musb_init_controller() does in the
> error path.
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/bug/linux-d180c2b9-0006-4638-a22b-13df8c201235
> Fixes: 39cee200c23e ("usb: musb: core: call init and shutdown for the usb phy")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/usb/musb/musb_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 73ac25f53698..8e52246de948 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2642,6 +2642,7 @@ static void musb_remove(struct platform_device *pdev)
>  	musb_disable_interrupts(musb);
>  	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
>  	spin_unlock_irqrestore(&musb->lock, flags);
> +	usb_phy_shutdown(musb->xceiv);
>  	musb_platform_exit(musb);
>  
>  	pm_runtime_dont_use_autosuspend(musb->controller);
> @@ -2650,7 +2651,6 @@ static void musb_remove(struct platform_device *pdev)
>  	musb_phy_callback = NULL;
>  	if (musb->dma_controller)
>  		musb_dma_controller_destroy(musb->dma_controller);
> -	usb_phy_shutdown(musb->xceiv);
>  	musb_free(musb);
>  	device_init_wakeup(dev, 0);
>  }
> 
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261107-usb-uaf-fix-bedcd9cd8f4b
> 
> Best regards,
> -- 
> Joshua Crofts
> 

Does not apply to the usb-linus branch, please rebase and resend.

thanks,

greg k-h

  parent reply	other threads:[~2026-11-20 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 11:46 [PATCH] usb: musb: fix use-after-free in musb_remove() Joshua Crofts
2026-11-07 11:56 ` sashiko-bot
2026-11-20 14:11 ` Greg Kroah-Hartman [this message]
2026-11-20 14:25   ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112054-sweep-flap-b94d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=b-liu@ti.com \
    --cc=balbi@ti.com \
    --cc=crofts@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox