From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795281835; b=bgoRIi1Ao2faJzTzBdPv3FHseVwvarCospyDJE0AB+9eM5H3PkVqw7L/hbplkqGHxdG9 J7dFqdLidFSf/jzqyoviHeiJsbbutgFk18ZB/yx24MGgGoPSDwDu6CTYqINH9FSIQ8cAa kUuiECkOZX2HfYLSgQKHIk/33do5zqOYra6JdjJZQbwRY1MbQ5blUHwutK7u7bkykawne 2dVdIOUWuf+h2k2GyVZAsyIOlSABylPKQSzHUieLglIHpcZoyfV9aYud9XoVea0hs6PNX vgXEpXkKxLtHrGm74+7bMErHTiobGf0wLG36BtB/ZRhSq6VR7oKEUQhDz/DTRXNtJUA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795281835; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=DoN+jG5Rec1QoyXW9HZrwy95eguN461fzv/CVFtCCEg=; b=Ze9LRWM0PKwy/vatMxAYSWQmyowXaTjqRut+adbyTQJ8cnTAq5ARMUiEvpNZMJLtoHaF ROw/tkgxbu5XSN8rivxeN/obCR8opxv6k0fdGxQGGK5Pk/gSld+1MAk70BiqJ7P8XqTqX iHJVRsH1IJs4J+1yfbHu6iVeL/ZXfCLDNgiZ7cAMBq0ZwgPTpF5fnkguqAdF3OKgB7A9J G46NuGn9ZXvHwscY3nNNxtozZPy3UPgOyMzQRNJCQ8ytCNC4TBYiyZc0ICNsXolxTtxSl 7CBFwRlj/Y4UQ8BPF6b0x3Fr7Ke60uxklAKx4aUaCptmTKX5pwwgrOALqlYlOc7khxw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=F3gb6nun; arc=none smtp.remote-ip=209.85.128.54 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B0C7606A320 for ; Sat, 21 Nov 2026 17:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3B0C7606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=F3gb6nun Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4bb64c99d2fso19648295e9.3 for ; Sat, 21 Nov 2026 09:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795281834; x=1795886634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=DoN+jG5Rec1QoyXW9HZrwy95eguN461fzv/CVFtCCEg=; b=F3gb6nunfOxohpA7FVOv6KfnszdYpDb9WP82vTw19QrSAAmnQG3pE0GqjqKbDi9k0H jUZFucmuBDSwmrthhIWCCjB7a+zhwww4n4cZ5w95TW7bwOeUAjNNHywm1DZE//YGUaCm d8GX9lZ2n39RKAlgNP81zHrRvwc62Ywo41UBMAHgZ3JG5xkSsZFCjxJP+7BLC5hQaiA/ 35GR6GwEKWOc2+UOM1HikHRfMwohnsH6GNNtycB1iyGXr2L12nerQIeDyU/0mnvQ7Iz0 q1BHqsxkxOzpeIARsvVKxc2GIFQp7HJHwGxgkrDfloOQ1t/kt1zrQEhnwHySTm1wOW6j RUhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795281834; x=1795886634; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DoN+jG5Rec1QoyXW9HZrwy95eguN461fzv/CVFtCCEg=; b=w3pO/lvm4Hgs1tOlEw+zhkguhVBPMvghSJio6j+b3s0Cp+vyQL5kl/ORpUJ0XDTGur emamVCPL1Qw+BrebayfQqrgleT0lZL07KFvXTmUEpNEbEj8pisqXAd87x6NlhHFVqJ6N oLGkHLDyRD8nGShnc1+CqU9dCe8VnL1GGEOLk6OgIJt19eq3sxKNqk/B4jvhlFObfJIG gP0XsRBBQmmUhyAZ4L/odGkwdgn298ppUY2RJFTU63zNGD5jAHI4wqZqAK0kMDdZC0Fw zL7EpnSPb4kOyVPtocv+gFGzvrtUGy2yFA7oPYVF2CLsSq5gHeQddelcEq8qPsD8yDsv 4otg== X-Forwarded-Encrypted: i=1; AL+hErGIbnI6NJl4jGM2cO98MpuNwYT8EJdolRdD+oxu3QpDUDfyYyFKOmU0YZAXdMOaHQe3XJzv2Di9hb8=@vger.kernel.org X-Gm-Message-State: APuU4Z/5vZAuxD7bUeHXdTrKnVpoxb+fV5CvPdt5UVlRMQoQGdlguwbi Layod7fljz48jNPGpYOZp8rxU1wtXWfr3e/hsQFVuBOjVf4qii8KBRSd X-Gm-Gg: AZFdTZeKRb+SMJ2UUxUHgFBfSx/w7iz2BU4Xtvy3XCEyWSbL3ok3ZxPZ4p3mWjH/tuD KV15n7nVyz1FSHmc3FqUCRpeTm+rTmKhWBIZGvuqvy5w8CTzbt46jQTXZCTKCCYF/WXgaAFMn/L GkCSMef4m0cNRYuuHx5t9/D0aUnFS5vHY7RgHMLf6Q0tp47gVefmO9OeuHfitZuKyoOe7BagnC8 iI2aAQp2/JdmJbu8hG8N5U2KVnfWUpolv0WhAF3DBxkHEOXQWQsacgeCdGUtoNHnYD6pVrw7KPT yEe26UPOJBZb22yF0WewrX3momsOKHnnZqnr//A9FQmAL7vhHEI5u+4M5rCzIm+wTc7cru2v4ok 9YkV6RUSTRSwdp/CzreOyxz5ljiRAmFLH+fNer/fR0DflIwNbTlME3OBEtWER2vh5qeOh8OG6iD uB7wKv9tXHuXzO4VY+uRqbJ2CK2Nj0heEL4rcub3hOSCsAeXaK6jpPRvikMmJHqqiuw61FVa9H0 FIkiaA4aYfGhT+uaGVLHg6gd/zFdJl0T5bKd6tI5ZTpTqW8fYNCxhCu+67ct3QlHhaEtwLor7OI mqjH5CDcP81RmY1P1IbYUN1+XT/EKFJSR9VZvKyALJPzecJYGlKgFnIugRMyHJaUaG0oLGY5snH C X-Received: by 2002:a05:600c:8b5c:b0:4bb:741d:ea0 with SMTP id 5b1f17b1804b1-4bb8880f621mr154274825e9.17.1795281833492; Sat, 21 Nov 2026 09:23:53 -0800 (PST) Received: from DESKTOP-V28CTA4.localdomain ([37.111.157.16]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb8538b2c5sm207307265e9.5.2026.11.21.09.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2026 09:23:53 -0800 (PST) From: Arbab Haider To: Alan Stern , Greg Kroah-Hartman Cc: Shichao Lai , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, syzbot+dc208a8cf8d37cf3e5ac@syzkaller.appspotmail.com, stable@vger.kernel.org, Arbab Haider Subject: [PATCH] usb-storage: alauda: track media_initialized per port Date: Sat, 21 Nov 2026 22:19:56 +0500 Message-ID: <20261121171956.1455-1-arbabhaider649@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 16637fea001a ("usb-storage: alauda: Check whether the media is initialized") added a media_initialized flag to struct alauda_info to prevent divide-by-zero errors when alauda_init_media() has not succeeded. However, Alauda devices expose two LUNs (us->max_lun = 1) backed by info->port[0] (xD) and info->port[1] (SmartMedia). Storing media_initialized in struct alauda_info shares it across both ports: once port 0 initializes, media_initialized becomes true, allowing port 1 to skip alauda_init_media() when its media-change bit is clear and divide by port[1].uzonesize == 0 in alauda_read_data() or alauda_write_lba(): Oops: divide error: 0000 [#1] SMP KASAN NOPTI RIP: 0010:alauda_read_data drivers/usb/storage/alauda.c:953 [inline] RIP: 0010:alauda_transport+0xe5a/0x35c0 drivers/usb/storage/alauda.c:1187 Additionally, alauda_check_media() never cleared media_initialized when media was removed or before re-initializing on media change, leaving it true if a subsequent re-initialization failed. Move media_initialized into struct alauda_media_info so each port tracks its own initialization state, and clear it when media is absent or before re-initializing on media change. Reported-by: syzbot+dc208a8cf8d37cf3e5ac@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=dc208a8cf8d37cf3e5ac Fixes: 16637fea001a ("usb-storage: alauda: Check whether the media is initialized") Cc: stable@vger.kernel.org Signed-off-by: Arbab Haider --- drivers/usb/storage/alauda.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index 5e7f99ba8..5493f25a7 100644 --- a/drivers/usb/storage/alauda.c +++ b/drivers/usb/storage/alauda.c @@ -96,6 +96,8 @@ struct alauda_media_info { u16 **lba_to_pba; /* logical to physical block map */ u16 **pba_to_lba; /* physical to logical block map */ + + bool media_initialized; }; struct alauda_info { @@ -105,8 +107,6 @@ struct alauda_info { unsigned char sense_key; unsigned long sense_asc; /* additional sense code */ unsigned long sense_ascq; /* additional sense code qualifier */ - - bool media_initialized; }; #define short_pack(lsb,msb) ( ((u16)(lsb)) | ( ((u16)(msb))<<8 ) ) @@ -471,6 +471,7 @@ static int alauda_check_media(struct us_data *us) || ((status[1] & 0x01) == 0)) { usb_stor_dbg(us, "No media, or door open\n"); alauda_free_maps(&MEDIA_INFO(us)); + MEDIA_INFO(us).media_initialized = false; info->sense_key = 0x02; info->sense_asc = 0x3A; info->sense_ascq = 0x00; @@ -478,12 +479,13 @@ static int alauda_check_media(struct us_data *us) } /* Check for media change */ - if (status[0] & 0x08 || !info->media_initialized) { + if (status[0] & 0x08 || !MEDIA_INFO(us).media_initialized) { usb_stor_dbg(us, "Media change detected\n"); alauda_free_maps(&MEDIA_INFO(us)); + MEDIA_INFO(us).media_initialized = false; rc = alauda_init_media(us); if (rc == USB_STOR_TRANSPORT_GOOD) - info->media_initialized = true; + MEDIA_INFO(us).media_initialized = true; info->sense_key = UNIT_ATTENTION; info->sense_asc = 0x28; info->sense_ascq = 0x00; -- 2.53.0