From: Rosen Penev <rosenp@gmail.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] usb: xhci-pci: don't perform Soft Retry on the AMD X470 chipset host
Date: Sat, 21 Nov 2026 21:49:22 -0800 [thread overview]
Message-ID: <20261122054922.50251-1-rosenp@gmail.com> (raw)
Commit a4a251f8c235 ("usb: xhci: do not perform Soft Retry for some xHCI
hosts") disabled Soft Retry on the 300 series Promontory hosts, which
fail to resume an endpoint after it. The X470 chipset host (1022:43d0)
has the same problem.
With an RT3070 USB Wi-Fi adapter (rt2800usb) on an X470 port, the
bulk IN endpoint sees one USB Transaction Error while the interface is
brought up. xhci soft-retries it with a Reset Endpoint command that
preserves the transfer state, the endpoint context reads back as
running, and no transfer completes on it again: the adapter receives
frames (its RX FIFO overflow counter climbs) but none reach the host.
Booting with xhci_hcd.quirks=0x10000000000 (XHCI_NO_SOFT_RETRY) lets
the URB complete with an error instead, rt2x00usb resubmits it and
reception keeps working.
Cc: stable@vger.kernel.org
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/usb/host/xhci-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index e278db940a58..0a8b5b04e324 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -88,6 +88,7 @@
#define PCI_DEVICE_ID_AMD_PROMONTORYA_3 0x43ba
#define PCI_DEVICE_ID_AMD_PROMONTORYA_2 0x43bb
#define PCI_DEVICE_ID_AMD_PROMONTORYA_1 0x43bc
+#define PCI_DEVICE_ID_AMD_X470_XHCI 0x43d0
#define PCI_DEVICE_ID_ATI_NAVI10_7316_XHCI 0x7316
@@ -493,7 +494,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
if (pdev->vendor == PCI_VENDOR_ID_AMD &&
(pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_2 ||
- pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4))
+ pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4 ||
+ pdev->device == PCI_DEVICE_ID_AMD_X470_XHCI))
xhci->quirks |= XHCI_NO_SOFT_RETRY;
if (pdev->vendor == PCI_VENDOR_ID_ZHAOXIN) {
--
2.56.1
next reply other threads:[~2026-11-22 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 5:49 Rosen Penev [this message]
2026-11-22 5:52 ` [PATCH] usb: xhci-pci: don't perform Soft Retry on the AMD X470 chipset host sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122054922.50251-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox