From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA6EC433F5 for ; Fri, 11 Mar 2022 13:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348751AbiCKNIP (ORCPT ); Fri, 11 Mar 2022 08:08:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232658AbiCKNIN (ORCPT ); Fri, 11 Mar 2022 08:08:13 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 769071C1ED0 for ; Fri, 11 Mar 2022 05:07:08 -0800 (PST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 43C9C3F203 for ; Fri, 11 Mar 2022 13:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647004027; bh=ozI/X9bOo7IR4Nc9BURhpXRb3lcz1fTkzuVpvV/bLVo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fb2hnFTidmWf4WnwqMz0EEbPLf5VmN9oyfAify4S0DpUBMa842XkOmd3VCGK4eKJ7 N5KOhC15EJ9ss2qqWoieoXn+wh3h/ExAeCm3GB7GxZTaco5mJzKlcFbIv9TTtc24eA UEyiTagpsdsrrayLWHp0Mqc3WUCV/C5tKTMqPTHHzntzCL7BLB3/bNItCFr5oVyze0 10rWaKCBy9/gWip95AIDgXyXUmw2ZA8hpj84Ev5mwFLDPf9tMDklDE1eBuKr1PAbG5 O2ZqoHDK7TYaG9v+rH/hcDrVZYJrkn7uVX9zyZ6LdEW9mPVV3KukDkMIcbt4XY/6CR Ud25qtFN1yrnw== Received: by mail-wm1-f71.google.com with SMTP id 84-20020a1c0257000000b00389a203e5adso2659582wmc.2 for ; Fri, 11 Mar 2022 05:07:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ozI/X9bOo7IR4Nc9BURhpXRb3lcz1fTkzuVpvV/bLVo=; b=716iE2gE7p8G9woApgQLFRhL98L6qGh2IkE3THVujvjmKxETcOq4VN2o8B9weHb0EZ zq+XJQQeteYa5BFFuYQCx2wtd7KAWlNomYyRyCYJnsV3jY46CkoVq/KuCfjEulXOFm+M K4Is9GYbFx/ISJYTN+v6PXsP0a7VxX6edhCl+E97ihqVKAIgoPm0wmnRDW8jogUqw4UT Vyc9apZuYBRGb+NZlzRtPfFTeB2HVSnIBiHXSigV/Sxy7p6wsxgzIb35fzkyE3WSv68P eO2Z/WGliH9xIvUMMNP7iWyAtuVTZfjZV/+wzG8LaRO8FI5Uatl/MhmMa/PvbKKeRkHj Kx4Q== X-Gm-Message-State: AOAM532yPJDrBOAHJkhBnzyiCE5ZjtO3iAvxwKj8IY2vNdZpuzNu5Cii cW3kuE0ypengiomX25zlAu9ZKGKG0OW8fmNvkAapIEXHvhDisxgh5sqFg9pH5FR5Ep5+mRCygAK m0gij7VIUiocqrsmKcubPZ1XJSZeJd7tzsjahpg== X-Received: by 2002:a05:600c:38a:b0:389:ed94:b6d9 with SMTP id w10-20020a05600c038a00b00389ed94b6d9mr2396901wmd.111.1647004026416; Fri, 11 Mar 2022 05:07:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwd3vC+SdiuTXpeR6B8nxf1LHBqm7SaiKDkXDHvm1xWl5JJREqguSxOuUHzGiKNui30mqa3og== X-Received: by 2002:a05:600c:38a:b0:389:ed94:b6d9 with SMTP id w10-20020a05600c038a00b00389ed94b6d9mr2396891wmd.111.1647004026194; Fri, 11 Mar 2022 05:07:06 -0800 (PST) Received: from [192.168.0.148] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id n16-20020a5d4010000000b001f07772457csm6425237wrp.101.2022.03.11.05.07.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 05:07:05 -0800 (PST) Message-ID: <2065a687-b634-b8f6-9dd9-8b8855464f40@canonical.com> Date: Fri, 11 Mar 2022 14:07:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] dt-bindings: usb: USB2512x boost value for up- and downstream ports Content-Language: en-US To: "Neumann, Bastian" , "devicetree@vger.kernel.org" Cc: Rob Herring , Richard Leitner , "linux-usb@vger.kernel.org" References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 11/03/2022 13:09, Neumann, Bastian wrote: > This patch adds devicetree documentation for signal boosting properties. > > Signed-off-by: Bastian Neumann > --- > .../devicetree/bindings/usb/usb251xb.txt | 22 +++++++++++++++++++ This looks familiar... is it a v2? > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt > index 1a934eab175e..538ae49fc31d 100644 > --- a/Documentation/devicetree/bindings/usb/usb251xb.txt > +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt > @@ -68,6 +68,26 @@ Optional properties : > - swap-dx-lanes : Specifies the ports which will swap the differential-pair > (D+/D-), default is not-swapped. > > +Electrical signal boosting > +The controller supplies a "boosting" functionality to drive up the USB > +electrical signals. This could result in non-USB compliant parameters > +(one example would be J/K level test). This should be <0x00> unless specific > +implementation issues requiew additional signal boosting to correct for deraded > +USB signaling levels: > + - <0x00> : Normal electrical drive strength (no boost) > + - <0x01> : Elevated drive strength low (~4% boost) > + - <0x02> : Elevated drive strength medium (~8% boost) > + - <0x03> : Elevated drive strength high (~12% boost) > + > + - boost-up : USB electrical signaling drive strength boost for upstream port. > + - boost-1 : USB electrical signaling drive strength boost for port 1. > + - boost-2 : USB electrical signaling drive strength boost for port 2. > + - boost-3 : USB electrical signaling drive strength boost for port 3. > + - boost-4 : USB electrical signaling drive strength boost for port 4. > + - boost-5 : USB electrical signaling drive strength boost for port 5. > + - boost-6 : USB electrical signaling drive strength boost for port 6. > + - boost-7 : USB electrical signaling drive strength boost for port 7. > + > Examples: > usb2512b@2c { > compatible = "microchip,usb2512b"; > @@ -86,4 +106,6 @@ Examples: > serial = "1234567890A"; > /* correct misplaced usb connectors on port 1,2 */ > swap-dx-lanes = <1 2>; > + boost-up = <0x00>; /* no boost for upstream port */ > + boost-1 = <0x02>; /* medium boost on port 1 */ > }; > -- > 2.30.2 > > > ----------------------------------------------------------------------------------------------------------- > Sirona Dental Systems GmbH > Sitz der Gesellschaft / registered address: Fabrikstraße 31, 64625 Bensheim > Registergericht / court of registry: Amtsgericht Darmstadt, HRB 24948 > Geschäftsführer / Managing Director: Dr. Cord Stähler, Jan Siefert, Rainer Raschke > Aufsichtsratsvorsitzender / Chairman of the Supervisory Board: Dr. Alexander Voelcker > > ----------------------------------------------------------------------------------------------------------- > > > Diese E-Mail ist ausschliesslich fuer den angesprochenen Adressaten > bestimmt und kann vertrauliche Informationen beinhalten. > -- > This e-mail is intended only for the designated recipient(s). It may > contain confidential or proprietary information. Please drop it. Since I am not on recipients list one could think I am not designated recipient. This defeats entire purpose of public discussion. Instead to public lists emails which are entirely public. Best regards, Krzysztof