From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E14BC433F5 for ; Mon, 13 Sep 2021 11:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9E2360F92 for ; Mon, 13 Sep 2021 11:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239698AbhIMLvq (ORCPT ); Mon, 13 Sep 2021 07:51:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35885 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239186AbhIMLvp (ORCPT ); Mon, 13 Sep 2021 07:51:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631533829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hHEoDHq70Y8LZ9UwHpfMsPaoDNaiVP1tazOGJebc6Y=; b=H0mYZRkaCc5PprjGLeLdFGP66GMqtPAAu72Ptw2n8MziFBNJIJp55ZFT6d86X+ujZfQESD S/TFbXZ4HE4YIDPqiGjXKi95X0slrAMzGGMxFB2WzDusAVy9ksPSiq0rW3dMF7diMSpMpd kQ9Cy6hbE3wjTto4Vhf/VZEUe/vuljM= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-XaP1bgB6P4y6XvH2WlSLrA-1; Mon, 13 Sep 2021 07:50:28 -0400 X-MC-Unique: XaP1bgB6P4y6XvH2WlSLrA-1 Received: by mail-ed1-f71.google.com with SMTP id z17-20020a05640240d100b003cac681f4f4so4769381edb.21 for ; Mon, 13 Sep 2021 04:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1hHEoDHq70Y8LZ9UwHpfMsPaoDNaiVP1tazOGJebc6Y=; b=123gNnlVT0ENOV+9goLMIbvuKUDK231/7k9/TOJbL5GX9b5ViFc5ijcGnAtYqyWBuW q1AJe9S3pT1Bgdo/CavNP6wzK3RkvFuoKvTGFfs+OFliDlcRTLEX8rHSgapeN8R0S7jE xMNatyns7hEfEe1VCGeT9UDI8KawM8W2nedkzy9s7GAXE2ZRoqwA6DrlyNaSHGCdnNIK 8oyn3xXrL24xUGsZJrc0RrP1DrMqYQrNBHe3frivC+5eGKvHl1fDe6PUrVgXzinhOWxw TEAQvX5uH/G258ly7IrqjjMiNsRF9GhRc65E48bSMURsm/PupQB1uZ870qH37vQzsA4l EQNA== X-Gm-Message-State: AOAM533YebAGHc3CWqNvTE8KjntlEUHk8f1AaZVXwBoIP8GW8mI0+9vk Ood9/BHjuSBiBRWfSrCgZEQVtRFjAAmqvBleIlKh/eokVcKAVdWOJNtcM5Fu/XG1YPqRIose7t+ z1dHraS9MtTdvgGU9MxnS2ldFEoVQ6fRuOA+hamGdrdSTbgvNshO8B8zVQvD0p6Lqz75sT8Ck X-Received: by 2002:a50:eacc:: with SMTP id u12mr12715970edp.140.1631533826932; Mon, 13 Sep 2021 04:50:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoVUTvAg4hxlZQ0vdoI1FDH0I9nEyrFSN8XJc/ZMPtGARxcusRePtQhMU6OsNMYKwfXuW6sg== X-Received: by 2002:a50:eacc:: with SMTP id u12mr12715961edp.140.1631533826776; Mon, 13 Sep 2021 04:50:26 -0700 (PDT) Received: from x1.localdomain ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id kx17sm3354791ejc.51.2021.09.13.04.50.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 04:50:26 -0700 (PDT) Subject: Re: Lacie Rugged USB3-FW does not work with UAS To: Oliver Neukum , Julian Sikorski Cc: Nathan Stratton Treadway , USB list References: <1566595393.8347.56.camel@suse.com> <5f8f8e05-a29b-d868-b354-75ac48d40133@gmail.com> <1567424535.2469.11.camel@suse.com> <2a06a5dd-3fc9-0aac-a7e2-67be35e2d6bb@gmail.com> <20190904155831.GE4337@nathanst.com> <1568033125.365.17.camel@suse.com> <4c2b1c8a-4126-ccfe-3431-323c4935566e@suse.com> <56cebf15-cf9d-475f-b388-b2be723697f6@gmail.com> <830f09f8-7e16-425e-d5dc-2c5102ee4c7a@redhat.com> <25e6ce5a-4732-8ffa-4805-9bf95859214b@gmail.com> <87a80ce7-7f66-627a-20ad-791cb971ffaf@redhat.com> <1f6c3026-143a-2004-24da-1da56e6305be@suse.com> From: Hans de Goede Message-ID: <2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com> Date: Mon, 13 Sep 2021 13:50:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1f6c3026-143a-2004-24da-1da56e6305be@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, On 9/13/21 1:06 PM, Oliver Neukum wrote: > > On 13.09.21 09:38, Hans de Goede wrote: >>> Hi, >>> >>> I have just updated my backups with f+k quirks enabled and everything worked without errors. Given that nobody appears to be aware of a sure test case for checking whether f alone is sufficient, should I just generate a patch enabling fk instead of u? >> Yes I believe that switching from fk to u, like done on the other Lacie entries is best. > > Hi, > > just to be sure that we are really on the same page. > > Do you really want to go to u - US_FL_IGNORE_UAS? The other one > has fk - US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME We currently have u - US_FL_IGNORE_UAS, because Julian's initial patch did that and that was merged. What we are talking about now, is moving from the big-hammer 'u' to fk - US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME, since testing has show that just 'fk' is enough, allowing us to keep using uas. > I may be a bit confused and I think we need to make sure first, that we are > talking about the same things. I hope that my reply above helps to clear things up. Regards, Hans