Re: [PATCH 5/7] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/04/2025 11:43, Ze Huang wrote:
>>> +	priv->phy = devm_phy_create(dev, NULL, &spacemit_combphy_ops);
>>> +	if (IS_ERR(priv->phy))
>>> +		return dev_err_probe(dev, PTR_ERR(priv->phy),
>>> +				     "failed to create combphy\n");
>>> +
>>> +	dev_set_drvdata(dev, priv);
>>> +	phy_set_drvdata(priv->phy, priv);
>> Both make no sense. Look what this function does.
> 
> It does seem redundant at first glance, but pdev->dev is the parent of 
> phy->dev.
> pdev->dev->driver_data will be used in spacemit_combphy_xlate()
> phy->dev->driver_data  will be used in phy_ops functions
> 
> I've checked some other drivers that did the same:
>      - phy-zynqmp.c at lines 990 and 1026
>      - phy-rockchip-samsung-hdptx.c at lines 1989 and 2000

Indeed, right. It's fine.

Best regards,
Krzysztof