public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
	Prike Liang <Prike.Liang@amd.com>
Subject: Re: [PATCH v5] usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir
Date: Wed, 2 Jun 2021 10:13:21 -0500	[thread overview]
Message-ID: <218c7f43-a2df-60cd-ce00-f4b3e8cf336d@amd.com> (raw)
In-Reply-To: <YLedxEnOOWPfMYec@kroah.com>

On 6/2/2021 10:03, Greg Kroah-Hartman wrote:
> On Thu, May 27, 2021 at 10:45:34AM -0500, Mario Limonciello wrote:
>> The XHCI controller is required to enter D3hot rather than D3cold for AMD
>> s2idle on this hardware generation.
>>
>> Otherwise, the 'Controller Not Ready' (CNR) bit is not being cleared by
>> host in resume and eventually this results in xhci resume failures during
>> the s2idle wakeup.
>>
>> Suggested-by: Prike Liang <Prike.Liang@amd.com>
>> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-usb%2F1612527609-7053-1-git-send-email-Prike.Liang%40amd.com%2F&amp;data=04%7C01%7Cmario.limonciello%40amd.com%7C07d80c804533439da6ad08d925d798a8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637582430177777264%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=uV%2FMr7rXtBVzNmEBg%2FrIoXVKfLAjdQOO4rkR8DrdhBw%3D&amp;reserved=0
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/usb/host/xhci-pci.c | 7 ++++++-
>>   drivers/usb/host/xhci.h     | 1 +
>>   2 files changed, 7 insertions(+), 1 deletion(-)
> 
> Should it go to stable kernels, and if so, how far back?
> 
> thanks,
> 
> greg k-h
> 

Sure, as far back as 5.11 makes sense to me.

      reply	other threads:[~2021-06-02 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 15:45 [PATCH v5] usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir Mario Limonciello
2021-06-02 15:03 ` Greg Kroah-Hartman
2021-06-02 15:13   ` Limonciello, Mario [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=218c7f43-a2df-60cd-ce00-f4b3e8cf336d@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Prike.Liang@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox