From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: kieran.bingham@ideasonboard.com, b-liu@ti.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@kernel.org,
stern@rowland.harvard.edu, rogerq@ti.com
Subject: [1/6] usb: uvc: include videodev2.h in g_uvc.h
Date: Wed, 10 Oct 2018 16:42:51 +0300 [thread overview]
Message-ID: <21991723.GNvD0vKHyi@avalon> (raw)
Hi Paul,
Thank you for the patch.
On Wednesday, 10 October 2018 05:48:58 EEST Paul Elder wrote:
> V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in
> videodev2.h, which is not included and causes a compiler warning:
>
> linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here
> (not in a function) #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START +
> 0)
>
> Include videodev2.h in g_uvc.h.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This is independent of the rest of the series so I've taken it in my tree
already, with the subject line modified to use "usb: gadget: uvc:" as a
prefix.
> ---
> include/uapi/linux/usb/g_uvc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/usb/g_uvc.h b/include/uapi/linux/usb/g_uvc.h
> index 3c9ee3020cbb..6698c3263ae8 100644
> --- a/include/uapi/linux/usb/g_uvc.h
> +++ b/include/uapi/linux/usb/g_uvc.h
> @@ -11,6 +11,7 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
> #include <linux/usb/ch9.h>
> +#include <linux/videodev2.h>
>
> #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0)
> #define UVC_EVENT_CONNECT (V4L2_EVENT_PRIVATE_START + 0)
next reply other threads:[~2018-10-10 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 13:42 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-10 2:48 [1/6] usb: uvc: include videodev2.h in g_uvc.h Paul Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21991723.GNvD0vKHyi@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul.elder@ideasonboard.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox