* [1/6] usb: uvc: include videodev2.h in g_uvc.h
@ 2018-10-10 2:48 Paul Elder
0 siblings, 0 replies; 2+ messages in thread
From: Paul Elder @ 2018-10-10 2:48 UTC (permalink / raw)
To: laurent.pinchart, kieran.bingham
Cc: Paul Elder, b-liu, gregkh, linux-usb, linux-kernel, balbi, stern,
rogerq
V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in
videodev2.h, which is not included and causes a compiler warning:
linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here (not in a function)
#define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0)
Include videodev2.h in g_uvc.h.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
include/uapi/linux/usb/g_uvc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/usb/g_uvc.h b/include/uapi/linux/usb/g_uvc.h
index 3c9ee3020cbb..6698c3263ae8 100644
--- a/include/uapi/linux/usb/g_uvc.h
+++ b/include/uapi/linux/usb/g_uvc.h
@@ -11,6 +11,7 @@
#include <linux/ioctl.h>
#include <linux/types.h>
#include <linux/usb/ch9.h>
+#include <linux/videodev2.h>
#define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0)
#define UVC_EVENT_CONNECT (V4L2_EVENT_PRIVATE_START + 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [1/6] usb: uvc: include videodev2.h in g_uvc.h
@ 2018-10-10 13:42 Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2018-10-10 13:42 UTC (permalink / raw)
To: Paul Elder
Cc: kieran.bingham, b-liu, gregkh, linux-usb, linux-kernel, balbi,
stern, rogerq
Hi Paul,
Thank you for the patch.
On Wednesday, 10 October 2018 05:48:58 EEST Paul Elder wrote:
> V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in
> videodev2.h, which is not included and causes a compiler warning:
>
> linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here
> (not in a function) #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START +
> 0)
>
> Include videodev2.h in g_uvc.h.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This is independent of the rest of the series so I've taken it in my tree
already, with the subject line modified to use "usb: gadget: uvc:" as a
prefix.
> ---
> include/uapi/linux/usb/g_uvc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/usb/g_uvc.h b/include/uapi/linux/usb/g_uvc.h
> index 3c9ee3020cbb..6698c3263ae8 100644
> --- a/include/uapi/linux/usb/g_uvc.h
> +++ b/include/uapi/linux/usb/g_uvc.h
> @@ -11,6 +11,7 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
> #include <linux/usb/ch9.h>
> +#include <linux/videodev2.h>
>
> #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0)
> #define UVC_EVENT_CONNECT (V4L2_EVENT_PRIVATE_START + 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-10 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-10 13:42 [1/6] usb: uvc: include videodev2.h in g_uvc.h Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2018-10-10 2:48 Paul Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).