From: Jiri Slaby <jirislaby@kernel.org>
To: Mychaela Falconia <mychaela.falconia@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/6] serial: core: add sysfs attribute to suppress ready signalling on open
Date: Thu, 2 Jun 2022 10:50:17 +0200 [thread overview]
Message-ID: <22ccc180-a3ab-77cf-a771-00113e712ac4@kernel.org> (raw)
In-Reply-To: <CA+uuBqacb3X+km-3EtdRxaWi0FvxZWCv8RpCo-+qaNkT-=JAgw@mail.gmail.com>
On 02. 06. 22, 10:35, Mychaela Falconia wrote:
> Jiri Slaby wrote:
>
>> s@ttyS0@ttyS<x>@
>> [...]
>> sysfs_emit()? (Even if I know %d won't overflow PAGE_SIZE :P.)
>
> Thanks for the feedback - saving it for v3 of my patch series.
>
> Any comments, positive or negative, on the principal/philosophical
> idea behind this proposed patch series?
Neutral. As long as you break no currently supported devices.
I've just noticed the double negative "!tty_port_nordy()" on both calls
of that function. I guess there was already a discussion about the
naming, but wouldn't it make more sense to dub it like tty_port_do_rtscts()?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-06-02 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 4:33 [PATCH v2 0/6] serial ports: add ability to suppress raising DTR & RTS on open Mychaela N. Falconia
2022-05-31 4:36 ` [PATCH v2 1/6] tty: add port flag to suppress ready signalling " Mychaela N. Falconia
2022-05-31 4:36 ` [PATCH v2 2/6] serial: core: add sysfs attribute " Mychaela N. Falconia
2022-06-02 7:48 ` Jiri Slaby
2022-06-02 8:35 ` Mychaela Falconia
2022-06-02 8:50 ` Jiri Slaby [this message]
2022-06-02 17:03 ` Mychaela Falconia
2022-05-31 4:37 ` [PATCH v2 3/6] serial: core: fully suppress raising DTR & RTS on open if nordy is set Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 4/6] USB: serial: add sysfs attribute to suppress ready signalling on open Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 5/6] USB: serial: ftdi_sio: pass port to quirk port_probe functions Mychaela N. Falconia
2022-05-31 4:37 ` [PATCH v2 6/6] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Mychaela N. Falconia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ccc180-a3ab-77cf-a771-00113e712ac4@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mychaela.falconia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox