From: Oliver Neukum <oneukum@suse.com>
To: John Ernberg <john.ernberg@actia.se>,
Oliver Neukum <oneukum@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Ming Lei <ming.lei@canonical.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] net: usbnet: Avoid potential RCU stall on LINK_CHANGE event
Date: Tue, 15 Jul 2025 13:49:06 +0200 [thread overview]
Message-ID: <22e2c652-7861-48d2-b769-79b2ef4ea878@suse.com> (raw)
In-Reply-To: <20250710085028.1070922-1-john.ernberg@actia.se>
On 10.07.25 10:50, John Ernberg wrote:
> Having a Gemalto Cinterion PLS83-W modem attached to USB and activating the
> cellular data link would sometimes yield the following RCU stall, leading
> to a system freeze:
[..]
> if (!netif_carrier_ok(dev->net)) {
> /* kill URBs for reading packets to save bus bandwidth */
> + usbnet_pause_rx(dev);
> unlink_urbs(dev, &dev->rxq);
> + usbnet_resume_rx(dev);
This will schedule work.
Do you really want that?
Regards
Oliver
prev parent reply other threads:[~2025-07-15 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:50 [PATCH] net: usbnet: Avoid potential RCU stall on LINK_CHANGE event John Ernberg
2025-07-14 23:35 ` Jakub Kicinski
2025-07-15 7:15 ` John Ernberg
2025-07-15 13:54 ` Jakub Kicinski
2025-07-16 14:54 ` John Ernberg
2025-07-16 21:39 ` Jakub Kicinski
2025-07-18 9:07 ` John Ernberg
2025-07-18 23:18 ` Jakub Kicinski
2025-07-23 9:29 ` John Ernberg
2025-07-15 11:49 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e2c652-7861-48d2-b769-79b2ef4ea878@suse.com \
--to=oneukum@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.ernberg@actia.se \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox