From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1B0C7EE2E for ; Fri, 9 Jun 2023 15:38:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241562AbjFIPiu (ORCPT ); Fri, 9 Jun 2023 11:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237997AbjFIPit (ORCPT ); Fri, 9 Jun 2023 11:38:49 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D642E35A7 for ; Fri, 9 Jun 2023 08:38:45 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-977cf86aae5so293425766b.0 for ; Fri, 09 Jun 2023 08:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686325124; x=1688917124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jorRTe9x5lJeJhWfN/tUaEbK9cETxBDWnzXXAk2nPIU=; b=LoTlSmKD8bjtAmd0AQnZrlssa8ZiOjN5pw90ZA+Nx4ze9+O4IXxvyRQJ12U+HCekvG NuIpZEEqfYz/lIwanx4zEDhAHu4nRAWAfVElS61M04uvzM++LbvDq9CNl4vf91hJIdPZ MaFmTMRgJbekFuzszLbGkriejLMK+WHquwo77er2yzrUuwirMAGYeoGnjKyLklLnr4j8 MsBfXGpFcgOKxtiD2bZv6fsDPuEprwkIUp4SrOaC5qDQVh0TgfDLkud021KMQ7xJARKo J19bBo9p+IC9iSIoZLKFeccwg3VYNyZ3soF5xuFLrvJorMgcf1+Ee2n1ci0GD64UfQJL vu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686325124; x=1688917124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jorRTe9x5lJeJhWfN/tUaEbK9cETxBDWnzXXAk2nPIU=; b=XQboozOa9A+LAa5mPN33WefCGshxNl1QXSxgqHaibNogf1hZ0tBdKgfl7cGCHEmWYB 3d393Ys4kdx+uaQqJ+lq1Pwy07pAP6Y7eVh8n4fttUT086GYMoybEfnPB5Rc/yL+BQ+e ij0h/DOBzbJEsSO4JyeN6A7+IAcxld7WK2qiEMH0d5HSYacluBQaqqoBoXdvLucjGYHY rE7PFixnx5/TH37hgEppGRbqSdBTqwhyHI7MRU9me+6l4SKQmbEcaL8YAtIraS0xMRYk /yK/GHdPKLH6VEZDmWo/kx0cR7jiHIymbL4GptJ1dxvDv3rPytp0XAzBHPE4rn8MvJEO rzFQ== X-Gm-Message-State: AC+VfDyo3ZWvZmyjJVuZY0n6V8J8Cdwdx7nKlTMVgNspMEIDP5fH6pKG E4rrXr60Cgs2Lku7wEEi+seaJg== X-Google-Smtp-Source: ACHHUZ7Wu5jmfQjkYkox8N1dR5VIsH+RE9uA5DNord0lEbqHRXmFw/c2UNSs/zPBWk9kJ5cszg9boQ== X-Received: by 2002:a17:906:fd85:b0:969:f54c:dee2 with SMTP id xa5-20020a170906fd8500b00969f54cdee2mr1905215ejb.26.1686325124285; Fri, 09 Jun 2023 08:38:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id a12-20020a17090680cc00b0096f7105b3a6sm1418119ejx.189.2023.06.09.08.38.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 08:38:43 -0700 (PDT) Message-ID: <22e3c25e-487b-c02f-46f3-6d2ab2be8813@linaro.org> Date: Fri, 9 Jun 2023 17:38:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH V2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt to yaml Content-Language: en-US To: Piyush Mehta , p.zabel@pengutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, michal.simek@xilinx.com, nava.manne@xilinx.com Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, siva.durga.prasad.paladugu@amd.com, git@amd.com References: <20230609110447.151235-1-piyush.mehta@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20230609110447.151235-1-piyush.mehta@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 09/06/2023 13:04, Piyush Mehta wrote: > Convert the binding to DT schema format. It also updates the > reset-controller description. > > Signed-off-by: Piyush Mehta > --- > - Addressed the Krzysztof review comment: > - Update DT binding to fix the dt_binding_check warning. > ... > diff --git a/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml > new file mode 100644 > index 000000000000..a39b17599e05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Zynq UltraScale+ MPSoC and Versal reset binding Drop "binding" > + > +maintainers: > + - Piyush Mehta > + > +description: | > + The Zynq UltraScale+ MPSoC and Versal has several different resets. > + > + The PS reset subsystem is responsible for handling the external reset > + input to the device and that all internal reset requirements are met > + for the system (as a whole) and for the functional units. > + > + Please also refer to reset.txt in this directory for common reset > + controller binding usage. Device nodes that need access to reset > + lines should specify them as a reset phandle in their corresponding > + node as specified in reset.txt. > + > + For list of all valid reset indices for Zynq UltraScale+ MPSoC > + > + > + For list of all valid reset indices for Versal > + > + > +properties: > + compatible: > + enum: > + - xlnx,zynqmp-reset > + - xlnx,versal-reset > + > + "#reset-cells": > + const: 1 > + > +required: > + - compatible > + - "#reset-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include Drop, won't be needed after removing unrelated parts. > + > + firmware { Drop > + zynqmp_firmware: zynqmp-firmware { Drop, three level of indentations for that simple reset-controller... > + zynqmp_reset: reset-controller { > + compatible = "xlnx,zynqmp-reset"; > + #reset-cells = <1>; > + }; > + }; > + }; > + > + /* Specifying sata reset control of devices */ > + sata { > + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>; > + reset-names = "sata_rst"; > + }; Drop this - not related. > + > +... Best regards, Krzysztof